Repository navigation
Commit e398b67
committed
test(webview): make the provider-filter assertion bite in both seeding rows
CodeRabbit's point measured rather than argued. The two it.each rows share the store order
["Zoo Gateway", "Other", "Zoo Gateway 2"], so only one of them can ever fail
expect(...).not.toContain("Other"): with the stale profile first the every-profile loop breaks
before it reaches the non-gateway profile, so that row cannot observe the filter at all.
Mutants run against 27a2836, production untouched (blob 8a5977a, restored by content hash
after each):
- drop the provider filter in ensureZooGatewayProfileSeeded: fixture as shipped -> 1 of the 2
rows fails (expected [ 'Zoo Gateway', 'Other', ...1 ] to not include 'Other'); with "Other"
leading the store -> both rows fail. The assertion goes from one-row to two-row coverage.
- check only the first gateway profile (the bug the comment describes): 1 row fails on the
handleZooCodeCallback assertion, before and after the reorder, so the reorder does not weaken
the detection this fixture pair exists for.
- no mutant: 397 tests in the file pass.
Test-only: the store order of the two rows moves and the comment records why "Other" leads.
No assertion was added, weakened or deleted - nothing deleted here, duplicate or coverage - so
the number a maintainer needs is 0 deleted-duplicate, 0 deleted-coverage, 1 assertion made
load-bearing in a second row. Gates: prettier --check, tsc --noEmit -p . and eslint
--max-warnings=0 clean; vitest core/webview + core.config suites 44 files / 1304 tests green.1 parent 27a2836 commit e398b67
1 file changed
Lines changed: 7 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10006 | 10006 | | |
10007 | 10007 | | |
10008 | 10008 | | |
10009 | | - | |
10010 | | - | |
10011 | | - | |
10012 | | - | |
| 10009 | + | |
| 10010 | + | |
| 10011 | + | |
| 10012 | + | |
| 10013 | + | |
10013 | 10014 | | |
10014 | 10015 | | |
10015 | 10016 | | |
10016 | | - | |
| 10017 | + | |
10017 | 10018 | | |
10018 | 10019 | | |
10019 | 10020 | | |
10020 | 10021 | | |
10021 | | - | |
| 10022 | + | |
10022 | 10023 | | |
10023 | 10024 | | |
10024 | 10025 | | |
| |||
0 commit comments