Repository navigation
Commit e265d53
committed
test(config): cover the post-reset rollback the rejected-newer path depends on
CodeRabbit follow-up comment on the 4b3d007 review (Trivial, Functional Correctness,
Quick win) against ContextProxy.spec.ts:710-713. It held: the test added in 4b3d007
settles both post-reset writes successfully, so nothing exercises the rollback record that
a reset leaves empty. A regression that only records a landed write in persistedValues when
no newer write is still in flight passed every test in the file.
New test issues an older and a newer write for the same key after resetAllState(), resolves
the older one, rejects the newer one, and asserts the mirror reports the landed value -
both through getGlobalState() and through getValues(), which is the object export() reads.
That test kills the regression CodeRabbit described: recording persistedValues only for the
last write standing now fails it. Sweep over the handler: 6 of 7 mutants killed; the
survivor is still dropping writeSequences.clear() from the reset, unobservable behind the
generation guard.
ContextProxy.spec.ts: 48/48. Full unit suite 58 failed / 12009 passed, same 15 pre-existing
Windows failures. check-types: 114 pre-existing errors, none in a touched file. ESLint exits
0 with --max-warnings=0 and eslint-suppressions.json unchanged (a --prune-suppressions run
rewrote the file without changing any count; reverted).1 parent 4b3d007 commit e265d53
1 file changed
Lines changed: 26 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
712 | 712 | | |
713 | 713 | | |
714 | 714 | | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
715 | 741 | | |
716 | 742 | | |
717 | 743 | | |
| |||
0 commit comments