Repository navigation
Commit dec06df
committed
S4b (Zoo-Code-Org#1375): name the rejection the committed-publish rows were asserting
The three teardown-ownership rows moved to Promise.allSettled when the cancellation they
describe started landing after the guarded publish, and allSettled plus a status check is a
fine way to watch a promise reject - it is also how a row ends up asserting that something
rejected somewhere. Each of the three now binds the reason and asserts both halves of it:
the class, and the message that identifies the window the row describes - a cancellation
that arrived after the guarded publish had committed. A conflict from a different window
satisfies the class alone and would have let these rows pass for the wrong reason.
The durability row in guardedWrite.spec gains the other direction of the same state: a
full-file publish whose parent-directory fsync failed records a complete observation
(complete === true), because staysPartial is true only for an edit authorized by a partial
read - which is what the partial row beside it pins. A caveat about durability has to be
distinguishable from a half-applied write, and reporting the wrong one of the two would
have made the error nicer without making it true.
Test-only. DiffViewProvider 168 passed, guardedWrite 73 passed, eslint exit 0 and prettier
clean on both files, src/eslint-suppressions.json unchanged.1 parent 13a943d commit dec06df
2 files changed
Lines changed: 25 additions & 3 deletions
File tree
- src
- core/tools/__tests__
- integrations/editor/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1362 | 1362 | | |
1363 | 1363 | | |
1364 | 1364 | | |
| 1365 | + | |
| 1366 | + | |
| 1367 | + | |
| 1368 | + | |
1365 | 1369 | | |
1366 | 1370 | | |
1367 | 1371 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3726 | 3726 | | |
3727 | 3727 | | |
3728 | 3728 | | |
3729 | | - | |
| 3729 | + | |
| 3730 | + | |
| 3731 | + | |
| 3732 | + | |
| 3733 | + | |
| 3734 | + | |
| 3735 | + | |
3730 | 3736 | | |
3731 | 3737 | | |
3732 | 3738 | | |
| |||
3776 | 3782 | | |
3777 | 3783 | | |
3778 | 3784 | | |
3779 | | - | |
| 3785 | + | |
| 3786 | + | |
| 3787 | + | |
| 3788 | + | |
| 3789 | + | |
| 3790 | + | |
| 3791 | + | |
3780 | 3792 | | |
3781 | 3793 | | |
3782 | 3794 | | |
| |||
3861 | 3873 | | |
3862 | 3874 | | |
3863 | 3875 | | |
3864 | | - | |
| 3876 | + | |
| 3877 | + | |
| 3878 | + | |
| 3879 | + | |
| 3880 | + | |
| 3881 | + | |
| 3882 | + | |
3865 | 3883 | | |
3866 | 3884 | | |
3867 | 3885 | | |
| |||
0 commit comments