You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit cf67a79
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(dte): keep only the task-runtime-effort unit in this PR
CodeRabbit's out-of-scope check lists content this unit does not own. Those files come out, so
the diff matches the stated scope: transient task-local thinking-effort state on Task, its
per-request delivery at the four request sites, and the tests for that behaviour.
The dynamicThinkingEffort experiment flag is the experiment-flag unit, tracked by
Zoo-Code-Org#2079 and carried by its own PR. That removes
packages/types/src/experiment.ts, the DYNAMIC_THINKING_EFFORT registration in
src/shared/experiments.ts, the new packages/types/src/__tests__/experiment.test.ts, the flag
cases in src/shared/__tests__/experiments.spec.ts, the ExperimentalSettings and SettingsView
cases in webview-ui, the three getStateToPostToWebview cases and the whole
"webviewMessageHandler - experiments" describe in src/core/webview/__tests__/
webviewMessageHandler.spec.ts. Nothing in this unit's production code reads the flag - the only
readers anywhere in the tree were those specs - and the registration comment itself says the
toggle would only persist a flag with no model-facing effect until the PR that registers the
set_thinking_effort tool ships, so no code path here depends on what is being removed.
scripts/stryker-diff.mjs and scripts/stryker-diff.test.mjs carried only a reflow of the comment
explaining why the extension entry uses plugin-side related-test discovery; that text belongs to
the mutation-gate unit, and the behaviour assertions in both files are unchanged either way.
Two files stay and the description now names them. src/api/index.ts adds exactly the
ApiHandlerCreateMessageMetadata.reasoningEffort declaration (plus its type import and doc
comment): the four request sites in Task.ts spread the task-local override into that metadata
object, so the field is this unit's requirement, not another unit's. src/core/webview/__tests__/
ClineProvider.spec.ts keeps the case that the webview receives the active task's apiConfiguration
object - the projection contract that makes "the override never enters apiConfiguration" testable
from the provider side - and drops only the flag cases above.
Tests: core/webview/__tests__/ClineProvider.spec.ts, shared/__tests__/experiments.spec.ts and
core/task/__tests__/Task.runtime-thinking-effort.test.ts pass together (3 files, 332 tests);
webview-ui ExperimentalSettings.spec.tsx and SettingsView.spec.tsx pass (2 files, 32 tests);
tsc --noEmit is clean for src and for webview-ui. eslint --max-warnings=0 --prune-suppressions
leaves src/eslint-suppressions.json byte-identical (per-file rule counts compared
before/after: unchanged), and prettier --check is clean on the four files still differing from
the base.
0 commit comments