Repository navigation
Commit ce3b00a
committed
fix(webview): run each provider release once and drop the dispose-time hydrate
disposeInternal duplicated the teardown releases that dispose()s finally already
owns. Measured on 057e866, a single dispose() ran the diagnostics broker
release, removeAllListeners and McpServerManager.unregisterProvider twice
({"broker":2,"listeners":2,"unregister":2}), and because dispose() returns early
when _disposed is set, a second dispose() changed nothing - so the existing
idempotency test could not see the doubling. The releases now live only in the
finally, which is what the teardown bodys own comment already claimed.
The unawaited `void this.loadViewState()` in the teardown body came from the
merge resolution at 17890eb: neither parent carried it - one occurrence at
:563 on f4, one at :523 on f3, zero on origin/main. Starting a state load
against a provider that is already closing mutates view-local state
mid-teardown with no live view left to deliver to, so it is gone, and the seam
comment beside cleanupStep no longer claims a dispose-time load re-runs the
constructors hydrate.
Tests: the broker release, the listener removal and the MCP unregistration are
asserted to happen exactly once across a double dispose, and dispose is
asserted not to start a view-state load. Control with only the production
change reverted: the count test fails on 2/2/2 and the load test fails on one
call. With the fix ClineProvider.spec.ts is 459 passed, tsc and eslint clean.1 parent 057e866 commit ce3b00a
2 files changed
Lines changed: 63 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1599 | 1599 | | |
1600 | 1600 | | |
1601 | 1601 | | |
1602 | | - | |
1603 | 1602 | | |
1604 | 1603 | | |
1605 | 1604 | | |
1606 | 1605 | | |
1607 | | - | |
| 1606 | + | |
| 1607 | + | |
| 1608 | + | |
1608 | 1609 | | |
1609 | 1610 | | |
1610 | 1611 | | |
| |||
1698 | 1699 | | |
1699 | 1700 | | |
1700 | 1701 | | |
1701 | | - | |
1702 | | - | |
1703 | | - | |
1704 | | - | |
1705 | | - | |
1706 | | - | |
1707 | | - | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
1708 | 1705 | | |
1709 | 1706 | | |
1710 | 1707 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
3699 | 3700 | | |
3700 | 3701 | | |
3701 | 3702 | | |
| 3703 | + | |
| 3704 | + | |
| 3705 | + | |
| 3706 | + | |
| 3707 | + | |
| 3708 | + | |
| 3709 | + | |
| 3710 | + | |
| 3711 | + | |
| 3712 | + | |
| 3713 | + | |
| 3714 | + | |
| 3715 | + | |
| 3716 | + | |
| 3717 | + | |
| 3718 | + | |
| 3719 | + | |
| 3720 | + | |
| 3721 | + | |
| 3722 | + | |
| 3723 | + | |
| 3724 | + | |
| 3725 | + | |
| 3726 | + | |
| 3727 | + | |
| 3728 | + | |
| 3729 | + | |
| 3730 | + | |
| 3731 | + | |
| 3732 | + | |
| 3733 | + | |
| 3734 | + | |
| 3735 | + | |
| 3736 | + | |
| 3737 | + | |
| 3738 | + | |
| 3739 | + | |
| 3740 | + | |
| 3741 | + | |
| 3742 | + | |
| 3743 | + | |
| 3744 | + | |
| 3745 | + | |
| 3746 | + | |
| 3747 | + | |
| 3748 | + | |
| 3749 | + | |
| 3750 | + | |
| 3751 | + | |
| 3752 | + | |
| 3753 | + | |
| 3754 | + | |
| 3755 | + | |
| 3756 | + | |
| 3757 | + | |
| 3758 | + | |
3702 | 3759 | | |
3703 | 3760 | | |
3704 | 3761 | | |
| |||
0 commit comments