Repository navigation
Commit b97f68e
easonLiangWorldedtech
fix(editor): fail the approved save when the document save reports false
saveChanges() awaited the document save and dropped the returned boolean, so a
save that reported failure still ran the success bookkeeping and the caller was
told the approved content persisted. Capture the awaited result and throw a
typed DocumentSaveFailedError before the commit point and before any success
bookkeeping, so the caller keeps its rollback and the existing failure handling
runs. A true result behaves exactly as before; a save that rejects still
propagates as before.
This branch gates an on-commit callback after the save rather than a placeholder
release, so the ordering promise is derived for this branch: the callback must
not run when the save reported false. The statement is inherited from upstream
code that predates the chain; this branch is the earliest carrier that is still
open, so the shape is fixed here and the later branches port it forward
re-derived.
The regression doubles resolve an explicit false, so a double resolving
undefined cannot pass by accident. Negative controls: reverting to a bare await
reddens exactly the two save-false tests (2/88, the same two as the pre-fix
production run); moving the throw after the callback reddens exactly the
ordering test (1/88). Restored byte for byte, hash verified.
See tracking item 6106182216.1 parent 5ff7bea commit b97f68e
2 files changed
Lines changed: 86 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
29 | 43 | | |
30 | 44 | | |
31 | 45 | | |
| |||
359 | 373 | | |
360 | 374 | | |
361 | 375 | | |
362 | | - | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
363 | 384 | | |
364 | 385 | | |
365 | 386 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
3 | 8 | | |
4 | 9 | | |
5 | 10 | | |
| |||
996 | 1001 | | |
997 | 1002 | | |
998 | 1003 | | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
| 1050 | + | |
| 1051 | + | |
| 1052 | + | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
999 | 1062 | | |
1000 | 1063 | | |
1001 | 1064 | | |
| |||
0 commit comments