|
| 1 | +import { followUpDataSchema, hasUsableAnswer, suggestionItemSchema, type SuggestionItem } from "../followup.js" |
| 2 | + |
| 3 | +describe("hasUsableAnswer", () => { |
| 4 | + it("accepts a non-blank string answer", () => { |
| 5 | + expect(hasUsableAnswer({ answer: "Yes, proceed" })).toBe(true) |
| 6 | + }) |
| 7 | + |
| 8 | + it("accepts a non-blank answer with surrounding whitespace, including one that also carries a mode", () => { |
| 9 | + const withMode: SuggestionItem = { answer: " spaced ", mode: "code" } |
| 10 | + expect(hasUsableAnswer(withMode)).toBe(true) |
| 11 | + }) |
| 12 | + |
| 13 | + it("rejects an empty or whitespace-only answer", () => { |
| 14 | + expect(hasUsableAnswer({ answer: "" })).toBe(false) |
| 15 | + expect(hasUsableAnswer({ answer: " \n\t " })).toBe(false) |
| 16 | + }) |
| 17 | + |
| 18 | + it("rejects a missing answer (issue #1226)", () => { |
| 19 | + expect(hasUsableAnswer({})).toBe(false) |
| 20 | + expect(hasUsableAnswer({ answer: undefined })).toBe(false) |
| 21 | + }) |
| 22 | + |
| 23 | + it("rejects non-string answers from malformed transport data (issue #1226)", () => { |
| 24 | + expect(hasUsableAnswer({ answer: 42 })).toBe(false) |
| 25 | + expect(hasUsableAnswer({ answer: { mode_slug: "code" } })).toBe(false) |
| 26 | + expect(hasUsableAnswer({ answer: null })).toBe(false) |
| 27 | + }) |
| 28 | + |
| 29 | + it("rejects a null or undefined suggestion item", () => { |
| 30 | + expect(hasUsableAnswer(null)).toBe(false) |
| 31 | + expect(hasUsableAnswer(undefined)).toBe(false) |
| 32 | + }) |
| 33 | +}) |
| 34 | + |
| 35 | +describe("suggestionItemSchema", () => { |
| 36 | + it("accepts a suggestion without an answer (issue #1226)", () => { |
| 37 | + expect(suggestionItemSchema.parse({ mode: "code" })).toEqual({ mode: "code" }) |
| 38 | + }) |
| 39 | + |
| 40 | + it("still rejects a non-string answer", () => { |
| 41 | + expect(() => suggestionItemSchema.parse({ answer: 42 })).toThrow() |
| 42 | + }) |
| 43 | +}) |
| 44 | + |
| 45 | +describe("followUpDataSchema", () => { |
| 46 | + it("accepts suggestions with a mix of usable and missing answers (issue #1226)", () => { |
| 47 | + const parsed = followUpDataSchema.parse({ |
| 48 | + question: "Pick one?", |
| 49 | + suggest: [{ answer: "Yes" }, { mode: "code" }, { answer: undefined }], |
| 50 | + }) |
| 51 | + |
| 52 | + expect(parsed).toEqual({ |
| 53 | + question: "Pick one?", |
| 54 | + suggest: [{ answer: "Yes" }, { mode: "code" }, {}], |
| 55 | + }) |
| 56 | + }) |
| 57 | +}) |
0 commit comments