Skip to content

Commit 9cb3635

Browse files
chore: tighten the N1 test comments
1 parent c9b7fda commit 9cb3635

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

‎src/core/webview/__tests__/ClineProvider.spec.ts‎

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3590,9 +3590,7 @@ describe("ClineProvider", () => {
35903590

35913591
await provider["setViewStateId"]("__proto__")
35923592

3593-
// "__proto__" is rejected before assignment so a per-view entry can never be
3594-
// keyed through the Object.prototype setter: the temporary id stays active and
3595-
// nothing is persisted under the reserved name.
3593+
// "__proto__" is rejected before assignment, so nothing is persisted under it.
35963594
expect(provider["viewStateId"]).toBe(provider.viewId)
35973595
expect(mockContext.globalState.get("viewStates")).toBeUndefined()
35983596
expect(provider["viewLocalState"]).toEqual({})
@@ -3631,21 +3629,17 @@ describe("ClineProvider", () => {
36313629
contextProxy,
36323630
new WebviewFocusTracker(),
36333631
)
3634-
// Seed a pre-launch entry under the temporary id through the real write path,
3635-
// so the re-key has real work to do and records this instance as its author.
3632+
// Seed a pre-launch entry through the real write path so the re-key has work to do.
36363633
await provider["savePersistedViewState"]({ mode: "architect", updatedAt: 1 })
36373634

36383635
const setValueSpy = vi.spyOn(contextProxy, "setValue").mockRejectedValue(new Error("storage down"))
36393636

36403637
await expect(provider["setViewStateId"]("stable-sidebar-view")).rejects.toThrow("storage down")
36413638

3642-
// The failed id must not stick: the provider keeps its previous (temporary)
3643-
// id so a later launch retries registration and the load instead of the
3644-
// guard early-returning for an id that was never persisted.
3639+
// The failed id must not stick: the provider keeps its previous (temporary) id.
36453640
expect(provider["viewStateId"]).toBe(provider.viewId)
36463641

3647-
// A later retry succeeds once the storage write works again, and the
3648-
// pre-launch entry lands under the registered id.
3642+
// A later retry succeeds once the storage write works again.
36493643
setValueSpy.mockRestore()
36503644
await provider["setViewStateId"]("stable-sidebar-view")
36513645
expect(provider["viewStateId"]).toBe("stable-sidebar-view")

0 commit comments

Comments
 (0)