Repository navigation
Commit 8c4a0ec
committed
Re-adopt 14 upstream test declarations lost in the vps2 chain and pin the abort path
The .each-inclusive survivor audit of the merged tree against e943530 flagged 22 rows in
three specs. All 22 exist at the merge base 3ee042d and all three files are ours-only
paths, so nothing here was lost by the merge: 15 declarations were dropped by our chain when
it reworked these files, 7 rows are the rewrites themselves.
Re-adopted from main, bodies verbatim, harness lines included:
- webview-ui ExtensionStateContext.spec.tsx: the 13-declaration interning suite (main 145-581)
plus its expectMessages/InternSpy/cacheFor helpers, the StringCache import, the
ExtensionMessage type and afterEach(() => vi.restoreAllMocks()). 28 -> 41 declarations.
- registerCommands.spec.ts: 'creates diagnostics from all provider instances without requiring
a visible provider' plus the services/diagnostics module mock it needs. 50 -> 51.
One main case is superseded rather than re-adopted: plusButtonClicked 'no-op when no visible
provider' - our handler resolves the registered sidebar provider through postActions() and the
replacement case asserts 5 things where main asserted 1.
One real gap the audit surfaced: our chain moved all four enqueueProviderProfileMutation call
sites to runToCompletion, which left production's abort branch (ClineProvider.ts:445-446,
'aborting in-flight mutation') emitted but unasserted. Added a case that drives the
non-runToCompletion path through the private helper directly and pins the cancelled signal,
the log and the queue advance; three mutants (log text, removed abort, queue no longer
advancing on timeout) each kill it.
Controls: no-oping all 9 interning call sites fails 12 of the 13 re-adopted cases; emptying
the providers fan-out fails exactly the re-adopted diagnostics case; production was restored
byte-identical after every mutation. eslint --prune-suppressions stayed count-neutral
(3298 total, no file above max(base, ours, main)), prettier --check clean, tsc clean for src,
webview-ui and packages/types, core/misc/api/webview-ui/packages-types lanes green.1 parent 3f99274 commit 8c4a0ec
3 files changed
Lines changed: 506 additions & 0 deletions
File tree
- src
- activate/__tests__
- core/webview/__tests__
- webview-ui/src/context/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
110 | 114 | | |
111 | 115 | | |
112 | 116 | | |
| |||
279 | 283 | | |
280 | 284 | | |
281 | 285 | | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
282 | 301 | | |
283 | 302 | | |
284 | 303 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
996 | 996 | | |
997 | 997 | | |
998 | 998 | | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
999 | 1031 | | |
1000 | 1032 | | |
1001 | 1033 | | |
| |||
0 commit comments