Repository navigation
Commit 45795c8
committed
test(webview): drop the three duplicated top-level cases, name the second describe
The review thread measured true against bf7a9e9. Three cases appeared twice, identical
apart from indentation - "should merge concurrent persisted updates from separate provider
instances without lost viewStates", "should remove the buffered apiConfiguration when it is
cleared" and "should increment instance count for each new instance" each sat once inside a
describe and once as a direct child of describe("ClineProvider") - and describe("view state
persistence edge cases") appeared twice, so reports showed two groups under one name.
Deleted the three top-level copies; the in-describe copies stay byte-for-byte unchanged.
Renamed the second block to "view-local buffer: loading, setValue mutations and rollback",
which names what its four cases actually do: load the persisted mode, profile name and
resolved profile into viewLocalState; apply setValue mutations to global state and keep or
clear the buffered fields; drop the buffered apiConfiguration when it is cleared; roll back
the shared write when per-view persistence fails. The first block keeps the old title - its
eleven cases are all persisted-viewStates edge cases, which is what it says.
Survivor check before pushing: 349 test titles in the file before, 346 after; each of the
three names still appears exactly once and no title dropped to zero. Three other same-title
pairs exist ("handles case when no current task exists", "loads saved API config when
switching modes", "saves current config when switching to mode without config") and are left
alone: their bodies differ, so they are not duplicates of each other.
prettier --check, tsc --noEmit -p . and eslint --max-warnings=0 are clean, and vitest
core/webview is 34 files / 982 tests green. No production file is touched, so the scope
measure still reports the same 810 extension-package executable lines.1 parent bf7a9e9 commit 45795c8
1 file changed
Lines changed: 1 addition & 80 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6799 | 6799 | | |
6800 | 6800 | | |
6801 | 6801 | | |
6802 | | - | |
6803 | | - | |
6804 | | - | |
6805 | | - | |
6806 | | - | |
6807 | | - | |
6808 | | - | |
6809 | | - | |
6810 | | - | |
6811 | | - | |
6812 | | - | |
6813 | | - | |
6814 | | - | |
6815 | | - | |
6816 | | - | |
6817 | | - | |
6818 | | - | |
6819 | | - | |
6820 | | - | |
6821 | | - | |
6822 | | - | |
6823 | | - | |
6824 | | - | |
6825 | | - | |
6826 | | - | |
6827 | | - | |
6828 | | - | |
6829 | | - | |
6830 | | - | |
6831 | | - | |
6832 | | - | |
6833 | | - | |
6834 | | - | |
6835 | | - | |
6836 | | - | |
| 6802 | + | |
6837 | 6803 | | |
6838 | 6804 | | |
6839 | 6805 | | |
| |||
7012 | 6978 | | |
7013 | 6979 | | |
7014 | 6980 | | |
7015 | | - | |
7016 | | - | |
7017 | | - | |
7018 | | - | |
7019 | | - | |
7020 | | - | |
7021 | | - | |
7022 | | - | |
7023 | | - | |
7024 | | - | |
7025 | | - | |
7026 | | - | |
7027 | | - | |
7028 | | - | |
7029 | | - | |
7030 | | - | |
7031 | | - | |
7032 | | - | |
7033 | 6981 | | |
7034 | 6982 | | |
7035 | 6983 | | |
| |||
7279 | 7227 | | |
7280 | 7228 | | |
7281 | 7229 | | |
7282 | | - | |
7283 | | - | |
7284 | | - | |
7285 | | - | |
7286 | | - | |
7287 | | - | |
7288 | | - | |
7289 | | - | |
7290 | | - | |
7291 | | - | |
7292 | | - | |
7293 | | - | |
7294 | | - | |
7295 | | - | |
7296 | | - | |
7297 | | - | |
7298 | | - | |
7299 | | - | |
7300 | | - | |
7301 | | - | |
7302 | | - | |
7303 | | - | |
7304 | | - | |
7305 | | - | |
7306 | | - | |
7307 | | - | |
7308 | | - | |
7309 | 7230 | | |
7310 | 7231 | | |
7311 | 7232 | | |
| |||
0 commit comments