Skip to content

Commit 25afaa5

Browse files
fix(api): name the fetchers that actually bound models discovery
The comment at fetchers/requesty.ts:11 cited kenari, opencode-go and nanogpt as the in-tree precedent for the 10_000 ms discovery timeout. Read from the file text at this head: kenari.ts (109 lines), opencode-go.ts (135) and nanogpt.ts (119) contain no timeout at all, so the comment pointed a future reader at three files that never bounded this call. The two that do are io-intelligence.ts (axios timeout: 10_000 at line 69) and kimi-code.ts (KIMI_CODE_MODELS_TIMEOUT_MS = 10_000 with a setTimeout race), and the comment now names those. Comment only: no behaviour, no assertion, no suppression, no changeset, no CHANGELOG. prettier --check and eslint --max-warnings=0 clean on the touched file.
1 parent f5c2cce commit 25afaa5

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎src/api/providers/fetchers/requesty.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@ import { toRequestyServiceUrl } from "../../../shared/utils/requesty"
88
import { mergeAbortSignalAndTimeout, throwIfAborted } from "../utils/abort-signal"
99

1010
// Bounded wall-clock limit for the models discovery request. Without it a hung connection
11-
// would keep the request alive indefinitely; 10_000 ms matches the other in-tree axios
12-
// fetchers (kenari, opencode-go, nanogpt).
11+
// would keep the request alive indefinitely. The 10_000 ms figure matches the two
12+
// in-tree fetchers that bound the same call: io-intelligence.ts (axios timeout: 10_000) and
13+
// kimi-code.ts (KIMI_CODE_MODELS_TIMEOUT_MS = 10_000). kenari, opencode-go and nanogpt do not
14+
// bound this call at all, so they are not the precedent.// fetchers (kenari, opencode-go, nanogpt).
1315
const REQUESTY_MODELS_TIMEOUT_MS = 10_000
1416

1517
export async function getRequestyModels(

0 commit comments

Comments
 (0)