Repository navigation
Commit 1fa4e5a
committed
chore(webview): clear four cosmetic review rows on the settings-write path
These are the cosmetic rows from the review round on this branch, taken on the
head that carries the sibling-overlay and launch-order fixes.
- Scratch snapshots were committed by accident: remove the seven .cp-/.rc/
.rcspec captures and ignore those patterns from now on.
- webviewMessageHandler: drop the duplicated mode check from the
updateSettings loop. provider.setValue validates the slug against the custom
modes and returns before writing, and ClineProvider.spec covers that guard
through setValue; the loop only routes the key now. The invalid-mode log line
therefore comes from [ClineProvider#setValue] instead of [updateSettings].
- api.ts: a newTab start owns the panel it creates, so an expired view-state
readiness bound is a failure for it rather than the headless fallback the
sidebar path uses. Dispose the panel, log a disposal failure, and rethrow the
timeout instead of starting a task on shared defaults behind an empty tab.
- vscode.spec: assert what the storage-restricted fallback persists - the key,
a single write, and the view state id inside the payload - instead of only
that a read and a write happened.
Gate results on this commit: src tsc and webview-ui tsc clean, eslint clean on the
touched files, prettier --check unchanged, and the three touched specs pass
(webviewMessageHandler 181, api-task-control 30, vscode 20).1 parent ec3589e commit 1fa4e5a
13 files changed
Lines changed: 72 additions & 19070 deletions
File tree
- src
- core/webview
- __tests__
- extension
- __tests__
- webview-ui/src/utils/__tests__
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
0 commit comments