Skip to content

Commit 1fa4e5a

Browse files
chore(webview): clear four cosmetic review rows on the settings-write path
These are the cosmetic rows from the review round on this branch, taken on the head that carries the sibling-overlay and launch-order fixes. - Scratch snapshots were committed by accident: remove the seven .cp-/.rc/ .rcspec captures and ignore those patterns from now on. - webviewMessageHandler: drop the duplicated mode check from the updateSettings loop. provider.setValue validates the slug against the custom modes and returns before writing, and ClineProvider.spec covers that guard through setValue; the loop only routes the key now. The invalid-mode log line therefore comes from [ClineProvider#setValue] instead of [updateSettings]. - api.ts: a newTab start owns the panel it creates, so an expired view-state readiness bound is a failure for it rather than the headless fallback the sidebar path uses. Dispose the panel, log a disposal failure, and rethrow the timeout instead of starting a task on shared defaults behind an empty tab. - vscode.spec: assert what the storage-restricted fallback persists - the key, a single write, and the view state id inside the payload - instead of only that a read and a write happened. Gate results on this commit: src tsc and webview-ui tsc clean, eslint clean on the touched files, prettier --check unchanged, and the three touched specs pass (webviewMessageHandler 181, api-task-control 30, vscode 20).
1 parent ec3589e commit 1fa4e5a

13 files changed

Lines changed: 72 additions & 19070 deletions

File tree

‎.cp-base.txt‎

Lines changed: 0 additions & 5242 deletions
This file was deleted.

‎.cp-f6.txt‎

Lines changed: 0 additions & 5459 deletions
This file was deleted.

‎.cp-f7.txt‎

Lines changed: 0 additions & 5249 deletions
This file was deleted.

‎.gitignore‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,3 +67,6 @@ roo-cli-*.tar.gz*
6767
.prettier-check.txt
6868
.suites*.txt
6969
.tsc.txt
70+
.cp-*.txt
71+
.rc-*.txt
72+
.rcspec-*.txt

0 commit comments

Comments
 (0)