Repository navigation
Commit 1871993
committed
Read the staged bytes after staging, where the escape undo can use them
The escape-undo capture read the staged temp before _streamDataToFile had written it, so every
confined write that reached the publish failed with
`ENOENT: no such file or directory, open '<dir>/.<name>.new_<ts>_<rand>.tmp'`. CI's ubuntu leg
name is visible in the misc block of platform-unit-test (ubuntu-latest) at e3d6327 on
"confines a write whose symlink referent stays inside the confined directory" and "confines a
scope path that itself runs through a symlink and does not exist yet". Windows never showed it:
both rows are test.skipIf(process.platform === "win32"), and fs.symlinkSync of a file fails
EPERM on this box (measured, pinned node v22.23.4), so no local run of the misc shard executes
them - local tallies read 2116 passed / 17 skipped before and after.
The read now sits after the staging write and before any mode handling, so the bytes compared by
a post-commit escape undo are the bytes that were staged and a restrictive target mode cannot
turn the capture into a failure. A read failure still aborts the write, which is what the
surrounding comment already required.
At this commit the third ubuntu failure - "preserves a restrictive 0o600 target mode through the
atomic publish", expected 420 to be 384 - is still red by design: it is a separate mechanism and
the next commit is the one that answers it.
Gates on this commit's tree, pinned node v22.23.4 (box node 25.9.0): misc exit 0 with 2116
passed / 17 skipped (unchanged tallies, and it cannot prove the two rows above); tsc
-p src/tsconfig.json exit 0; prettier --check clean; eslint --max-warnings=0 exit 0.
Refs: Zoo-Code-Org#1375, Zoo-Code-Org#1991, Zoo-Code-Org#2019.1 parent e3d6327 commit 1871993
1 file changed
Lines changed: 9 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
382 | 382 | | |
383 | 383 | | |
384 | 384 | | |
385 | | - | |
386 | | - | |
387 | | - | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
388 | 393 | | |
389 | | - | |
390 | | - | |
391 | 394 | | |
392 | 395 | | |
393 | 396 | | |
394 | | - | |
395 | 397 | | |
396 | 398 | | |
397 | 399 | | |
| |||
569 | 571 | | |
570 | 572 | | |
571 | 573 | | |
572 | | - | |
| 574 | + | |
573 | 575 | | |
574 | 576 | | |
575 | 577 | | |
| |||
0 commit comments