Disallow writing with consolidated metadata #965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paraseba
force-pushed
the
push-vqomprvwrymp
branch
4 times, most recently
from
799519f to
88d818c
Compare
dcherian
reviewed
Jun 3, 2025
icechunk/src/store.rs
Outdated
| )] | ||
| InvalidVirtualChunkContainer { chunk_location: String }, | ||
| #[error( | ||
| "Icechunk has its own metadata consolidation mechanism. Please disable Zarr's metadata consolidation for writing data on Icechunk. If you are using Xarray, you can pass consolidate=False to to_zarr, or simply use Icechunk's to_icechunk which already disables consolidation." |
Contributor
There was a problem hiding this comment.
Suggested change
| "Icechunk has its own metadata consolidation mechanism. Please disable Zarr's metadata consolidation for writing data on Icechunk. If you are using Xarray, you can pass consolidate=False to to_zarr, or simply use Icechunk's to_icechunk which already disables consolidation." | |
| "Icechunk has its own metadata consolidation mechanism. Please disable Zarr's metadata consolidation for writing data on Icechunk. If you are using Xarray, you can pass `consolidated=False` to `Dataset.to_zarr`, or simply use `icechunk.xarray.to_icechunk` which disables consolidation." |
Contributor
|
My concern here is that this will break existing code & pipelines. |
paraseba
force-pushed
the
push-vqomprvwrymp
branch
from
88d818c to
d694e6a
Compare
Collaborator
Author
@dcherian: But, aren't those pipelines already broken because they are not setting |
paraseba
force-pushed
the
push-vqomprvwrymp
branch
5 times, most recently
from
e5c994c to
b06b186
Compare
Icechunk provides its own metadata consolidation mechanism. Closes #962
paraseba
force-pushed
the
push-vqomprvwrymp
branch
from
b06b186 to
d75973e
Compare
Collaborator
Author
|
We are going to use a different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icechunk provides its own metadata consolidation mechanism.
Closes #962