Skip to content

Avoid memory copy of the NumPy buffer when writing to an Icechunk store - #2332

Merged
li-em merged 3 commits into
earth-mover:mainfrom
tomwhite:avoid-mem-copy-in-write
Aug 19, 2026
Merged

Avoid memory copy of the NumPy buffer when writing to an Icechunk store#2332
li-em merged 3 commits into
earth-mover:mainfrom
tomwhite:avoid-mem-copy-in-write

Conversation

@tomwhite

@tomwhite tomwhite commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Fixes #2331

This code is the same as the change for obstore in zarr-developers/zarr-python#2972

@li-em

li-em commented Aug 18, 2026

Copy link
Copy Markdown
Member

thanks @tomwhite! I'll fix the other PR errors, they are not related to this change

@paraseba

paraseba commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

👏 thank you @tomwhite

@li-em
li-em enabled auto-merge August 19, 2026 21:56
@li-em
li-em added this pull request to the merge queue Aug 19, 2026
Merged via the queue into earth-mover:main with commit 827c4f8 Aug 19, 2026
33 checks passed
This was referenced Aug 21, 2026
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcherian dcherian dcherian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid memory copy of the NumPy buffer when writing to an Icechunk store

4 participants

@tomwhite @li-em @paraseba @dcherian