Repository navigation
fix(core): reject a stop_check workload shorter than concurrency x waves - #3
Merged
Merged
Conversation
first_turns() returns at most the file's conversations, but main() indexed prompts[i] for every request of every wave. With a short --data file the tool crashed with IndexError while submitting, after earlier requests had already been sent and with no output written. Check the count up front and exit with a usage message. Test: tests/test_stop_check.py fails before (IndexError), passes after.
Contributor
|
Merged in 508f021. Thanks for the fix and the test that fails without it. The export that publishes this repo first landed your fix without your name on it. I've fixed the export, and your original commit is now in main's history, so this PR shows as merged under your name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Licensing, attribution, and third-party content
and have preserved required license, copyright, attribution, and NOTICE text.
and the affected file or component (or an appropriately mapped change log).
repository's licensing and contain required third-party notices.
the Eagle Trademark Policy and preserved the required
non-affiliation and distinguishable-branding disclosures.
and any requirements stated in CONTRIBUTING.md.
Modified: 2026-10-22 by kevin9327, files: tools/stop_check.py, tests/test_stop_check.py (new). Existing copyright and SPDX headers are unchanged.
Change summary
tools/stop_check.pyreads the first--concurrency * --wavesconversations of--data(default 16 x 2 = 32), but never checked that the file had that many.prompts[i]then raisedIndexErrorinside the submit loop, after earlier requests had already hit the server and without writing--out. The fix checks the count right after reading and exits with a message naming the file, the count and what is needed. Touchestools/stop_check.pyand addstests/test_stop_check.py.Testing and impact
pytest tests/test_stop_check.py(new; stubstransformersandrequests, no server or tokenizer download): fails on main withIndexError, passes with the fix.tests/test_check_headers.pypasses for the new file.Lint:
ruff==0.15.1 checkon the changed files passes. CPU only; no GPU, model weights or torch needed.Third-party materials and dependencies
None
AI-assisted or generated content
Grok Bot (an AI assistant) helped find the bug by reading the code, and drafted the fix, the test and this description. I reviewed the diff and ran the new test before the fix (fails) and after (passes), plus the rest of the touched test file.
Documentation and notices
None