Repository navigation
fix(pkg): create simple/ before writing the index root page in mk_index - #2
Merged
Merged
Conversation
mk_index.py accepts zero artifacts (nargs="*") to regenerate an index, but simple/ was only created inside the per-project loop. On a fresh root with no artifacts the root page write raised FileNotFoundError. Create simple/ up front. Test: tests/test_wheel_index.py::test_empty_index_writes_root_page fails before, passes after.
Contributor
|
Merged in d5fcb65. Thanks for the fix and the test that fails without it. The export that publishes this repo first landed your fix without your name on it. I've fixed the export, and your original commit is now in main's history, so this PR shows as merged under your name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Licensing, attribution, and third-party content
and have preserved required license, copyright, attribution, and NOTICE text.
and the affected file or component (or an appropriately mapped change log).
repository's licensing and contain required third-party notices.
the Eagle Trademark Policy and preserved the required
non-affiliation and distinguishable-branding disclosures.
and any requirements stated in CONTRIBUTING.md.
Modified: 2026-10-22 by kevin9327, files: tools/mk_index.py, tests/test_wheel_index.py. Existing copyright and SPDX headers are unchanged.
Change summary
tools/mk_index.py <root>takes zero or more artifacts (nargs="*"), but<root>/simple/was only created inside the per-project loop. On a fresh root with no artifacts (or a files/ dir that is still empty), writingsimple/index.htmlfailed withFileNotFoundError. The fix createssimple/before the loop. Touchestools/mk_index.pyand its test.Testing and impact
pytest tests/test_wheel_index.py: the newtest_empty_index_writes_root_pagefails on main (traceback, exit 1) and passes with the fix; all 11 pass. Output for non-empty indexes is unchanged.Lint:
ruff==0.15.1 checkon the changed files passes. CPU only; no GPU, model weights or torch needed.Third-party materials and dependencies
None
AI-assisted or generated content
Grok Bot (an AI assistant) helped find the bug by reading the code, and drafted the fix, the test and this description. I reviewed the diff and ran the new test before the fix (fails) and after (passes), plus the rest of the touched test file.
Documentation and notices
None