allow all options in map:merge#2#4621
Merged
Merged
Conversation
line-o
added
bug
Reject by counting expected size of merge. Combine uses a merge-with-combine fn from the underlying collection code. Passes an initial set of tests. There’s some code we have written for completeness (MapType merge with combiner operator) which doesn’t seem to get called. Need to investigate/test further.
fixes eXist-db#4620 Check for existence of "duplicates" option first. Add test to ensure map:merge#2 with empty options behaves as map:merge#1.
line-o
force-pushed
the
fix/map-merge-2
branch
from
November 28, 2022 15:15
914415a to
8f0a956
Compare
|
SonarCloud Quality Gate failed. |
reinhapa
approved these changes
Nov 28, 2022
Contributor
|
@alanpaxton As you did the underlying work which is cherry-picked into here - would you mind taking a look and giving us an "Approve"/"Reject"? The goal in this PR is not to break backwards compatibility with 6.x.x. I would add you as a reviewer, but it seems to only let me choose core-team members! |
Collaborator
|
Approve. |
dizzzz
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map{ "duplicates": "combine" }andmap{ "duplicates": "reject" }Cherry-picked 3 commits from Switch map:merge from use-last to use-first as per XQuery spec #3738 and squashed them
These enhancements are non-breaking and can be merged in to develop before the next major release.