Skip to content

Conversation

@lemunozm
Copy link
Contributor

Fix 2 issues with microCDR:

  • Check the max size at deserialization functions (change the API).
  • Better management of the MicroCDR error that could generate indeterminate behaviour (change the error type in MicroBuffer struct)

Tests:

  • Refactor tests.
  • Added FullBuffer error tests.
  • Added SequenceOverflow tests
  • Added Endianness tests for all types.
  • Improvements in the current tests.

@lemunozm lemunozm changed the title Bugfix/security and Refactor/Added tests Added security and Refactor/Added tests Sep 18, 2018
@lemunozm lemunozm changed the title Added security and Refactor/Added tests Added security and refactor/added tests Sep 18, 2018
@lemunozm lemunozm requested a review from richiware September 18, 2018 10:41
@richiware richiware assigned lemunozm and unassigned richiware Sep 19, 2018
@lemunozm lemunozm assigned richiware and unassigned lemunozm Sep 19, 2018
@richiware richiware merged commit ba05196 into feature/strings Sep 19, 2018
@richiware richiware deleted the bugfix/security branch September 19, 2018 13:32
richiware pushed a commit that referenced this pull request Sep 21, 2018
* Refs #3327. Added string serialization

* Added security and refactor/added tests (#9)

* Refs #3390. Modify error checker, refactor project layout. Refactor serialization test. Refs #3389 Fix issue: now a serialization will be perform after any serialization error.

* Template tests

* Refs #3397. Refactored and improved tests.

* Refs #3397 #3389. API security changes. Added endianness tests.

* Added data_size checks. Added Sequence overflow test.

* Refs #3397. Change var name max_size -> array_size

* Refs #3397. Added functions to manage error/endianness

* Refs #3397. Moved check_buffer function to a common file

* Refs #3397. Modify array_capacity parameter position.

* Refs #3397. Refactor define names in test.

* Updated README with the new types.

* Refs #3397. Removed MicroState. Added a copy MicroBuffer function.

* Refs #3397. Updated README. Removed set_valid function.

* Refs #3397. Added error description to README.md
richiware pushed a commit that referenced this pull request Oct 19, 2018
* Modified the project strucure and updated the README with more info about the lib. (#7)

* Ref #3327. Added, documented and tested type: int8.

* #3328 Refactor headers

* Ref #3328. Refactor sources.

* #3328. Added documentation.

* Changes for accepting Pull Request #7

* Changes (2) for accepting Pull Request #7

* Added native string serialization (#8)

* Refs #3327. Added string serialization

* Added security and refactor/added tests (#9)

* Refs #3390. Modify error checker, refactor project layout. Refactor serialization test. Refs #3389 Fix issue: now a serialization will be perform after any serialization error.

* Template tests

* Refs #3397. Refactored and improved tests.

* Refs #3397 #3389. API security changes. Added endianness tests.

* Added data_size checks. Added Sequence overflow test.

* Refs #3397. Change var name max_size -> array_size

* Refs #3397. Added functions to manage error/endianness

* Refs #3397. Moved check_buffer function to a common file

* Refs #3397. Modify array_capacity parameter position.

* Refs #3397. Refactor define names in test.

* Updated README with the new types.

* Refs #3397. Removed MicroState. Added a copy MicroBuffer function.

* Refs #3397. Updated README. Removed set_valid function.

* Refs #3397. Added error description to README.md

* Refs #3408. Modified DLL exports (#10)

* Added mc prefix to MicroCDR (#11)

* Refs #3436. MicroBuffer => mcMicroBuffer

* Refs #3436. Added -mc at deserialization functions.

* Refs #3436. Added -mc at serialization functions.

* Recovered internal functions names.

* Refs #3436. Rename common functions.

* Refs #3436. Added mc preffix to endianness.

* Refs #3436. Added mc to README and example.

* Refs #3436. Modify mcMicroBuffer to mcBuffer

* Refs #3436. micro_buffer to buffer function names

* Refs #3436. Fix error.

* Refs #3436. Fix mc prefix at mrEndianness. Minor correction

* Fix windows warning

* Fix warnings

* Fix warnings

* Feature/prefix change (#13)

* Refs #3451. mc_ prefix to ucdr_ prefix

* Refs #3451. Modified dll export name

* Refs #3458. Updated internal symbols with prefix.

* #3451. Updated include path (#14)

* #3451. Updated include path

* Fixed cmake install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants