Skip to content

Fix incompatibility with FastCDR in fragmentation #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogs9 merged 5 commits into from
Nov 25, 2021
Merged

Fix incompatibility with FastCDR in fragmentation #69

pablogs9 merged 5 commits into from
Nov 25, 2021

Conversation

@pablogs9
Copy link
Contributor

@pablogs9 pablogs9 commented Nov 17, 2021

No description provided.

@pablogs9 pablogs9 requested a review from Acuadros95 November 17, 2021 13:01
@richiprosima
Copy link
Contributor

richiprosima commented Nov 17, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

richiprosima commented Nov 17, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

richiprosima commented Nov 17, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@gavanderhoorn gavanderhoorn mentioned this pull request Nov 17, 2021
Closed
@pablogs9 pablogs9 marked this pull request as draft November 17, 2021 13:59
@richiprosima
Copy link
Contributor

richiprosima commented Nov 17, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

richiprosima commented Nov 17, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9
Copy link
Contributor Author

pablogs9 commented Nov 18, 2021 •
edited
Loading

Checks:

Required:

@richiprosima
Copy link
Contributor

richiprosima commented Nov 18, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

richiprosima commented Nov 18, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

pablogs9
pablogs9 commented Nov 19, 2021
View reviewed changes
pablogs9
pablogs9 commented Nov 19, 2021
View reviewed changes
@richiprosima
Copy link
Contributor

richiprosima commented Nov 19, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

Acuadros95
Acuadros95 reviewed Nov 19, 2021
View reviewed changes
Acuadros95
Acuadros95 reviewed Nov 19, 2021
View reviewed changes
@pablogs9 pablogs9 marked this pull request as ready for review November 22, 2021 08:48
@pablogs9 pablogs9 requested a review from Acuadros95 November 22, 2021 08:48
@pablogs9 pablogs9 force-pushed the fix/fast_dds_incompatibility branch from f94a496 to b68120a Compare November 23, 2021 09:33
@richiprosima
Copy link
Contributor

richiprosima commented Nov 23, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

richiprosima commented Nov 23, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

richiprosima commented Nov 23, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

richiprosima commented Nov 23, 2021

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 merged commit c3420b6 into develop Nov 25, 2021
@pablogs9 pablogs9 deleted the fix/fast_dds_incompatibility branch November 25, 2021 13:49
@gavanderhoorn
Copy link
Contributor

gavanderhoorn commented Nov 25, 2021

thanks again for looking into this 👍 🎉

pablogs9 added a commit to micro-ROS/micro_ros_renesas_testbench that referenced this pull request Nov 25, 2021
@pablogs9
micro-CDR regression test eProsima/Micro-CDR#69 (#42)
35cd7b1 
* Initial

* Fix indent

* REMOVE LATER

* Update

* update regression test

* Revert "REMOVE LATER"

This reverts commit c607097.

Co-authored-by: Your Name <[email protected]>
mergify bot pushed a commit to micro-ROS/micro_ros_renesas_testbench that referenced this pull request Nov 25, 2021
@pablogs9
micro-CDR regression test eProsima/Micro-CDR#69 (#42)
5b61114 
* Initial

* Fix indent

* REMOVE LATER

* Update

* update regression test

* Revert "REMOVE LATER"

This reverts commit c607097.

Co-authored-by: Your Name <[email protected]>
(cherry picked from commit 35cd7b1)
mergify bot pushed a commit to micro-ROS/micro_ros_renesas_testbench that referenced this pull request Nov 25, 2021
@pablogs9
micro-CDR regression test eProsima/Micro-CDR#69 (#42)
4969543 
* Initial

* Fix indent

* REMOVE LATER

* Update

* update regression test

* Revert "REMOVE LATER"

This reverts commit c607097.

Co-authored-by: Your Name <[email protected]>
(cherry picked from commit 35cd7b1)
pablogs9 added a commit to micro-ROS/micro_ros_renesas_testbench that referenced this pull request Nov 25, 2021
@mergify @pablogs9
micro-CDR regression test eProsima/Micro-CDR#69 (#42) (#50)
91868a9 
* Initial

* Fix indent

* REMOVE LATER

* Update

* update regression test

* Revert "REMOVE LATER"

This reverts commit c607097.

Co-authored-by: Your Name <[email protected]>
(cherry picked from commit 35cd7b1)

Co-authored-by: Pablo Garrido <[email protected]>
pablogs9 added a commit to micro-ROS/micro_ros_renesas_testbench that referenced this pull request Nov 25, 2021
@mergify @pablogs9
micro-CDR regression test eProsima/Micro-CDR#69 (#42) (#49)
dec9877 
* Initial

* Fix indent

* REMOVE LATER

* Update

* update regression test

* Revert "REMOVE LATER"

This reverts commit c607097.

Co-authored-by: Your Name <[email protected]>
(cherry picked from commit 35cd7b1)

Co-authored-by: Pablo Garrido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Acuadros95 Acuadros95 Acuadros95 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogs9 @richiprosima @gavanderhoorn @Acuadros95