Bugfix in ucdr_reset_buffer function #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Build status:
|
Member
|
Build status:
|
pablogs9
approved these changes
May 4, 2020
pablogs9
pushed a commit
that referenced
this pull request
May 8, 2020
* Isolated install (#48) * Add isolated install flag. * Add isolated and non-isolated CI tests. * Fix Windows warning in CI. * Add colcon.pkg file. (#49) * Origin/Offset [7903] (#51) * Implement ucdr_advance_buffer function. * Add origin and offset to ucdrBuffer struct. * Refactor basic functions. * Fix ucdr_advance_buffer function. * Update README.md with the new functions provided. * Set project version to 1.2.0. * Bugfix in ucdr_reset_buffer function (#53) * Add unit tests for common functions. * Fix ucdr_reset_buffer function. Co-authored-by: Borja Outerelo <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
ucdr_reset_bufferfunction and adds regression tests.Please, take into account that the first commit doesn't contains the fix, so the CI shall failed.