Skip to content

Allow runing CI on external contributions test#5242

Closed
UAMiky wants to merge 1 commit intoeProsima:feature/allow_external_CIfrom
UAMiky:feature/allow_external_CI_test
Closed

Allow runing CI on external contributions test#5242
UAMiky wants to merge 1 commit intoeProsima:feature/allow_external_CIfrom
UAMiky:feature/allow_external_CI_test

Conversation

@UAMiky
Copy link
Copy Markdown

@UAMiky UAMiky commented Sep 18, 2024

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany self-requested a review September 18, 2024 07:54
@JesusPoderoso JesusPoderoso force-pushed the feature/allow_external_CI branch from 206be41 to e924aaa Compare September 18, 2024 08:27
@MiguelCompany MiguelCompany force-pushed the feature/allow_external_CI_test branch from 74dc5b0 to a100969 Compare September 19, 2024 07:17
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany September 19, 2024 07:17
@JesusPoderoso JesusPoderoso force-pushed the feature/allow_external_CI branch from e924aaa to c6ae1fd Compare October 2, 2024 08:48
@MiguelCompany MiguelCompany force-pushed the feature/allow_external_CI_test branch from a100969 to e2c4e10 Compare October 2, 2024 09:03
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Oct 2, 2024
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany October 2, 2024 09:03
@MiguelCompany MiguelCompany deleted the branch eProsima:feature/allow_external_CI October 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-test Skip CI tests if PR marked with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants