Skip to content

[23858] Build with warnings as errors#289

Merged
MiguelCompany merged 5 commits intomasterfrom
hotfix/werror
Oct 31, 2025
Merged

[23858] Build with warnings as errors#289
MiguelCompany merged 5 commits intomasterfrom
hotfix/werror

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Oct 30, 2025 •
edited by richiware
Loading

Description

Just what the title says. We want builds to fail if there are warnings.

@Mergifyio backport 2.2.x 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v2.3.4 milestone Oct 30, 2025
@MiguelCompany MiguelCompany requested review from richiware and removed request for richiware October 30, 2025 10:42
@MiguelCompany MiguelCompany changed the title Build with warnings as errors [23858] Build with warnings as errors Oct 30, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima October 30, 2025 11:09
@MiguelCompany
Refs #23858. Fix warning.
2e06e01 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima October 30, 2025 11:14
@richiware richiware requested review from richiprosima and richiware and removed request for richiware October 31, 2025 08:26
@richiware
Refs #23858. Move to CI
7029499 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware requested review from richiware and removed request for richiprosima October 31, 2025 08:31
richiware
richiware previously approved these changes Oct 31, 2025
View reviewed changes
MiguelCompany
MiguelCompany commented Oct 31, 2025
View reviewed changes
Comment thread .github/workflows/reusable-ci.yml Outdated
@richiware @MiguelCompany
Apply suggestion
32a9b92 
Co-authored-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
@richiware richiware self-requested a review October 31, 2025 09:06
MiguelCompany
MiguelCompany commented Oct 31, 2025
View reviewed changes
Copy link
Copy Markdown
Member Author

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 9beec7e into master Oct 31, 2025
12 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/werror branch October 31, 2025 09:14
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Oct 31, 2025

@Mergifyio backport 2.2.x 1.0.x

@mergify
Copy link
Copy Markdown

mergify Bot commented Oct 31, 2025 •
edited
Loading

backport 2.2.x 1.0.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Oct 31, 2025
@MiguelCompany @richiware @mergify
Build with warnings as errors (#289)
4ad5c78 
* Refs #23858. Build with warnings as errors.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Add option for MSVC

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Fix warning.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Move to CI

Signed-off-by: Ricardo González Moreno <[email protected]>

* Apply suggestion

Co-authored-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Co-authored-by: Ricardo González Moreno <[email protected]>
(cherry picked from commit 9beec7e)
mergify Bot pushed a commit that referenced this pull request Oct 31, 2025
@MiguelCompany @mergify
Build with warnings as errors (#289)
ac59440 
* Refs #23858. Build with warnings as errors.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Add option for MSVC

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Fix warning.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Move to CI

Signed-off-by: Ricardo González Moreno <[email protected]>

* Apply suggestion

Co-authored-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Co-authored-by: Ricardo González Moreno <[email protected]>
(cherry picked from commit 9beec7e)

# Conflicts:
#	test/SimpleTest.cpp
This was referenced Oct 31, 2025
Merged
Merged
MiguelCompany added a commit that referenced this pull request Oct 31, 2025
@mergify @MiguelCompany @richiware
Build with warnings as errors (#289) (#290)
a02c569 
* Refs #23858. Build with warnings as errors.



* Refs #23858. Add option for MSVC



* Refs #23858. Fix warning.



* Refs #23858. Move to CI



* Apply suggestion




---------





(cherry picked from commit 9beec7e)

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Co-authored-by: Ricardo González Moreno <[email protected]>
MiguelCompany added a commit that referenced this pull request Oct 31, 2025
@MiguelCompany
Build with warnings as errors (#289)
5ebf896 
* Refs #23858. Build with warnings as errors.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Add option for MSVC

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Fix warning.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Move to CI

Signed-off-by: Ricardo González Moreno <[email protected]>

* Apply suggestion

Co-authored-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Co-authored-by: Ricardo González Moreno <[email protected]>
(cherry picked from commit 9beec7e)

# Conflicts:
#	test/SimpleTest.cpp
MiguelCompany added a commit that referenced this pull request Oct 31, 2025
@MiguelCompany
Build with warnings as errors (#289)
7de4ab1 
* Refs #23858. Build with warnings as errors.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Add option for MSVC

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Fix warning.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Move to CI

Signed-off-by: Ricardo González Moreno <[email protected]>

* Apply suggestion

Co-authored-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Co-authored-by: Ricardo González Moreno <[email protected]>
(cherry picked from commit 9beec7e)

# Conflicts:
#	test/SimpleTest.cpp
MiguelCompany added a commit that referenced this pull request Oct 31, 2025
@mergify @MiguelCompany
Build with warnings as errors (#289) (#291)
e94597a 
* Refs #23858. Build with warnings as errors.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Add option for MSVC

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Fix warning.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Move to CI

Signed-off-by: Ricardo González Moreno <[email protected]>

* Apply suggestion

Co-authored-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Co-authored-by: Ricardo González Moreno <[email protected]>
(cherry picked from commit 9beec7e)

# Conflicts:
#	test/SimpleTest.cpp

Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiware richiware richiware approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v2.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @richiware