[23684] Fix mutable size-three optional serialization (backport #253)#277
Merged
MiguelCompany merged 1 commit into2.2.xfrom Sep 11, 2025
Merged
[23684] Fix mutable size-three optional serialization (backport #253)#277MiguelCompany merged 1 commit into2.2.xfrom
MiguelCompany merged 1 commit into2.2.xfrom
Conversation
* Refs #23684: Add regression test Signed-off-by: Jesus Perez <[email protected]> * Refs #23684: Fix mutable size-three optional serialization Signed-off-by: Jesus Perez <[email protected]> * Refs #23684: Uncrustify Signed-off-by: Jesus Perez <[email protected]> --------- Signed-off-by: Jesus Perez <[email protected]> (cherry picked from commit f00d560)
11 tasks
MiguelCompany
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes mutable calculate_serialized_size of a size-three optional type. XCDR2 EMHEADER size wrongly computed (4 bytes) for mutable optional field with size different from 1, 2, 4 or 8. It should have a 8 bytes EMHEADER.
@Mergifyio backport 2.2.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist
This is an automatic backport of pull request #253 done by [Mergify](https://mergify.com).