Skip to content

[23683] Fix default fixed-string length bug#275

Merged
MiguelCompany merged 3 commits intomasterfrom
fix/fixed_string_assign
Sep 10, 2025
Merged

[23683] Fix default fixed-string length bug#275
MiguelCompany merged 3 commits intomasterfrom
fix/fixed_string_assign

Conversation

@jepemi
Copy link
Copy Markdown
Contributor

@jepemi jepemi commented Sep 10, 2025 •
edited by MiguelCompany
Loading

Description

This PR fixes wrong behavior with fixed strings which had a default value longer than the serialized one.

@Mergifyio backport 2.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany self-requested a review September 10, 2025 06:51
MiguelCompany
MiguelCompany approved these changes Sep 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @jepemi!

LGTM with green CI

@MiguelCompany MiguelCompany changed the title [] Fix default fixed-string length bug [23683] Fix default fixed-string length bug Sep 10, 2025
@MiguelCompany MiguelCompany added this to the v2.3.1 milestone Sep 10, 2025
@jepemi jepemi force-pushed the fix/fixed_string_assign branch from e20aefd to 9e6f74b Compare September 10, 2025 07:13
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany September 10, 2025 07:13
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Sep 10, 2025

Uncrustify checked locally

@MiguelCompany MiguelCompany merged commit 60c176d into master Sep 10, 2025
11 checks passed
@MiguelCompany MiguelCompany deleted the fix/fixed_string_assign branch September 10, 2025 07:22
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Sep 10, 2025

@Mergifyio backport 2.2.x

@mergify
Copy link
Copy Markdown

mergify Bot commented Sep 10, 2025 •
edited
Loading

backport 2.2.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Sep 10, 2025
@jepemi @mergify
Fix default fixed-string length bug (#275)
8550d32 
* Refs #23683: Add regression unit test

Signed-off-by: Jesus Perez <[email protected]>

* Refs #23683: Add regression top test

Signed-off-by: Jesus Perez <[email protected]>

* Refs #23683: Fix implementation

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit 60c176d)
@mergify mergify Bot mentioned this pull request Sep 10, 2025
Merged
11 tasks
MiguelCompany pushed a commit that referenced this pull request Sep 10, 2025
@jepemi @MiguelCompany
Fix default fixed-string length bug (#275)
9a963cd 
* Refs #23683: Add regression unit test

Signed-off-by: Jesus Perez <[email protected]>

* Refs #23683: Add regression top test

Signed-off-by: Jesus Perez <[email protected]>

* Refs #23683: Fix implementation

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit 60c176d)
MiguelCompany pushed a commit that referenced this pull request Sep 10, 2025
@mergify @jepemi
Fix default fixed-string length bug (#275) (#276)
42db576 
* Refs #23683: Add regression unit test



* Refs #23683: Add regression top test



* Refs #23683: Fix implementation



---------


(cherry picked from commit 60c176d)

Signed-off-by: Jesus Perez <[email protected]>
Co-authored-by: Jesús Pérez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v2.3.1 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@jepemi @MiguelCompany