[22876] Make optional copy/move constructors actuate only if the storage is engaged (backport #264)#265
Merged
MiguelCompany merged 1 commit into2.2.xfrom Mar 19, 2025
Merged
Conversation
… engaged (#264) * Refs #22876: Add test Signed-off-by: Mario Dominguez <[email protected]> * Refs #22876: Make optionals copy/move constructors actuate only if the storage is engaged. Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 36c28c4)
12 tasks
MiguelCompany
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
optionalcopy/move constructors from other optionals to actuate only if the storage to copy from is engaged.This prevents undefined behavior in the placement new when copying/moving data that is not initialized.
Specially, it tends to throw
std::bad_array_new_lengthwhen trying to copy vectors.@Mergifyio backport 2.2.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist
This is an automatic backport of pull request #264 done by [Mergify](https://mergify.com).