Skip to content

Fix symbol visibility for exception classes#262

Merged
MiguelCompany merged 2 commits intomasterfrom
feature/22802
Mar 5, 2025
Merged

Fix symbol visibility for exception classes#262
MiguelCompany merged 2 commits intomasterfrom
feature/22802

Conversation

@Carlosespicur
Copy link
Copy Markdown
Contributor

@Carlosespicur Carlosespicur commented Feb 26, 2025

Description

This PR fixes the problem reported in #149, making Exception a base class that does not inherit from std::exception.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the behavior change in versions.md

Signed-off-by: Carlosespicur <[email protected]>
@MiguelCompany MiguelCompany self-requested a review March 5, 2025 10:32
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit 2008b80 into master Mar 5, 2025
@MiguelCompany MiguelCompany deleted the feature/22802 branch March 5, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants