[22329] Serialize single null-character for empty strings#249
Merged
MiguelCompany merged 2 commits intomasterfrom Nov 27, 2024
Merged
[22329] Serialize single null-character for empty strings#249MiguelCompany merged 2 commits intomasterfrom
MiguelCompany merged 2 commits intomasterfrom
Conversation
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
8f5df56 to
b8a15f5
Compare
rsanchez15
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #245 introduced a regression that made nightlies of Fast DDS 2.14.x fail. The serialization of empty strings should consist of a length=1 followed by a single null character.
This adds a regression test and removes the check for empty strings in the serialization code.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist