[21362] Fail when trying to serialize std::string with null characters on its content (backport #245)#246
Closed
mergify[bot] wants to merge 1 commit into2.1.xfrom
Closed
[21362] Fail when trying to serialize std::string with null characters on its content (backport #245)#246mergify[bot] wants to merge 1 commit into2.1.xfrom
std::string with null characters on its content (backport #245)#246mergify[bot] wants to merge 1 commit into2.1.xfrom
Conversation
…ts content (#245) * Refs #21362. Add test. Signed-off-by: Miguel Company <[email protected]> * Refs #21362. Fix Cdr behavior. Signed-off-by: Miguel Company <[email protected]> * Refs #21362. Fix FastCDR behavior. Signed-off-by: Miguel Company <[email protected]> * Refs #21362. Fix dll export. Signed-off-by: Miguel Company <[email protected]> * Refs #21362. Leave implementation in header. Signed-off-by: Miguel Company <[email protected]> * Refs #21362. Apply suggestion. Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Mario Domínguez López <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Mario Domínguez López <[email protected]> (cherry picked from commit 5cc8c55)
12 tasks
Member
|
Closing because 2.1.x is EOL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses #69 and #214 by explicitly failing to serialize a string that contains null characters, instead of silently discard the last part of the string.
@Mergifyio backport 2.1.x 1.0.x
Note: I'm not sure whether we should backport this to 1.x.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist
This is an automatic backport of pull request #245 done by [Mergify](https://mergify.com).