Skip to content

Use assign for deserialize instead of temporary std::string#241

Merged
MiguelCompany merged 1 commit intoeProsima:masterfrom
SamuelH91:assign
Dec 17, 2024
Merged

Use assign for deserialize instead of temporary std::string#241
MiguelCompany merged 1 commit intoeProsima:masterfrom
SamuelH91:assign

Conversation

@SamuelH91
Copy link
Copy Markdown
Contributor

@SamuelH91 SamuelH91 commented Oct 10, 2024 •
edited by MiguelCompany
Loading

Description

At deserialize of fixed_string (cdr) or string (fastcdr) temporary std::string was used which may allocate memory dynamically, which is not desirable or needed especially if using fixed_strings.

@Mergifyio backport 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

MiguelCompany
MiguelCompany requested changes Oct 10, 2024
View reviewed changes
Comment thread src/cpp/Cdr.cpp Outdated
Comment thread src/cpp/FastCdr.cpp Outdated
@MiguelCompany MiguelCompany added this to the v2.2.6 milestone Oct 10, 2024
@MiguelCompany MiguelCompany self-requested a review October 10, 2024 13:30
@MiguelCompany MiguelCompany changed the base branch from master to feature/22447 December 17, 2024 08:21
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Dec 17, 2024

@Mergifyio rebase

@mergify
Copy link
Copy Markdown

mergify Bot commented Dec 17, 2024

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany December 17, 2024 08:24
@MiguelCompany MiguelCompany deleted the branch eProsima:master December 17, 2024 08:28
@MiguelCompany MiguelCompany reopened this Dec 17, 2024
@MiguelCompany MiguelCompany changed the base branch from feature/22447 to master December 17, 2024 08:30
@MiguelCompany MiguelCompany self-requested a review December 17, 2024 08:31
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany December 17, 2024 08:36
MiguelCompany
MiguelCompany approved these changes Dec 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit 5b8025b into eProsima:master Dec 17, 2024
@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Dec 17, 2024

@SamuelH91 Thank you for your contribution and patience!

@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Dec 17, 2024

@Mergifyio backport 1.0.x

@mergify
Copy link
Copy Markdown

mergify Bot commented Dec 17, 2024 •
edited
Loading

backport 1.0.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Dec 17, 2024
@SamuelH91 @mergify
Use assign for deserialize instead of temporary std::string (#241)
c6fbc3c 
Signed-off-by: Samuel Hyyppä <[email protected]>
Co-authored-by: Samuel Hyyppä <[email protected]>
(cherry picked from commit 5b8025b)

# Conflicts:
#	include/fastcdr/Cdr.h
#	include/fastcdr/FastCdr.h
@mergify mergify Bot mentioned this pull request Dec 17, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v2.2.6 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

3 participants

@SamuelH91 @MiguelCompany @SamuelSandvik