#4991: Fix improper array access in sc_signup_extended_user_fields#4993
Merged
CaMer0n merged 1 commit intoe107inc:masterfrom Apr 21, 2023
Merged
#4991: Fix improper array access in sc_signup_extended_user_fields#4993CaMer0n merged 1 commit intoe107inc:masterfrom
CaMer0n merged 1 commit intoe107inc:masterfrom
Conversation
|
Code Climate has analyzed commit 1e601fb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 34.4% (-0.1% change). View more on Code Climate. |
Member
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes: #4991
Description
varset()is not a language builtin that can handle unset array keys likeisset() ? … : …can.This change replaces a
varset()with theisset() ? … : …style.How Has This Been Tested?
/signup.phpshows up now:Types of Changes
Checklist