#4938: Workaround for PHP 8.2.0 segmentation fault / assertion error#4939
Merged
CaMer0n merged 1 commit intoe107inc:masterfrom Jan 3, 2023
Merged
#4938: Workaround for PHP 8.2.0 segmentation fault / assertion error#4939CaMer0n merged 1 commit intoe107inc:masterfrom
CaMer0n merged 1 commit intoe107inc:masterfrom
Conversation
… error Casting a `SimpleXMLElement` to an array should be equivalent to `get_object_vars(…)` as far as I can tell. At least all existing tests pass and I don't see any visual regressions upon making this change. By replacing `get_object_vars(…)` with a cast to array, we sidestep this PHP 8.2.0 bug: php/php-src#10200 Fixes: e107inc#4938
|
Code Climate has analyzed commit 377da20 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 34.4% (-0.3% change). View more on Code Climate. |
Member
|
Thank you! 👍 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4938
Motivation and Context
e107 won't run on PHP 8.2.0 due to this bug: #4938 » php/php-src#10200
Description
Casting a
SimpleXMLElementto an array should be equivalent toget_object_vars(…)as far as I can tell. At least all existing tests pass and I don't see any visual regressions upon making this change.By replacing
get_object_vars(…)with a cast to array, we sidestep this PHP 8.2.0 bug: php/php-src#10200How Has This Been Tested?
Existing tests pass, and I don't see anything amiss when clicking around e107 with this patch.
Types of Changes
Checklist