Tests: MDEV-29446 workaround: Ignore COLLATE clause in SHOW CREATE TABLE#4913
Merged
CaMer0n merged 1 commit intoe107inc:masterfrom Dec 1, 2022
Merged
Tests: MDEV-29446 workaround: Ignore COLLATE clause in SHOW CREATE TABLE#4913CaMer0n merged 1 commit intoe107inc:masterfrom
CaMer0n merged 1 commit intoe107inc:masterfrom
Conversation
https://jira.mariadb.org/browse/MDEV-29446 changes the output of `SHOW CREATE TABLE`, which MySQL and MariaDB 10.2 and older do not do. To tolerate the new behavior, this change strips the `COLLATE` clause from the `SHOW CREATE TABLE` output to ignore it. Fixes: e107inc#4912
|
Code Climate has analyzed commit ae3c57a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 34.3% (-0.3% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Failing test:
Description
https://jira.mariadb.org/browse/MDEV-29446 changes the output of
SHOW CREATE TABLE, which MySQL and MariaDB 10.2 and older do not do.To tolerate the new behavior, this change strips the
COLLATEclause from theSHOW CREATE TABLEoutput to ignore it.Fixes: #4912
How Has This Been Tested?
Test modified
Types of Changes
Checklist