#4830: Sensible no delete log in admin_log_ui::maintenanceProcess()#4831
Merged
CaMer0n merged 1 commit intoe107inc:masterfrom Sep 29, 2022
Merged
#4830: Sensible no delete log in admin_log_ui::maintenanceProcess()#4831CaMer0n merged 1 commit intoe107inc:masterfrom
admin_log_ui::maintenanceProcess()#4831CaMer0n merged 1 commit intoe107inc:masterfrom
Conversation
|
Code Climate has analyzed commit 62b5c84 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 34.3% (-0.4% change). View more on Code Climate. |
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4830
Motivation and Context
$sql->mySQLresultcan't magically be turned into a string, so use the actual interface,e_db::getLastErrorText().Description
The SQL last error text will be printed, if any, when there are no system logs to delete in
/e107_admin/admin_log.php?mode=main&action=maintenance.How Has This Been Tested?
Types of Changes
Checklist