#4245 stay on correct page after editing paginated topic#4742
Merged
CaMer0n merged 1 commit intoe107inc:masterfrom Apr 2, 2022
Jimmi08:correct-url-after-editing-post-in-paginated-topic
Merged
#4245 stay on correct page after editing paginated topic#4742CaMer0n merged 1 commit intoe107inc:masterfrom Jimmi08:correct-url-after-editing-post-in-paginated-topic
CaMer0n merged 1 commit intoe107inc:masterfrom
Jimmi08:correct-url-after-editing-post-in-paginated-topic
Conversation
CLOSES #4245 Tested with PHP 8.1 Description: When you edit a post on the next page (with the paginated topic), after saving you are redirected to the first page and you don't see that edited message then. Changes added p parameter to edit URL in post options and edit image shortcodes used this parameter when redirecting after reply is updated it is not needed when updating the thread because you are always on the first page added check if it is the first page, then the parameter is not used (to have the same behavior as with thread). Tested PHP 7.4. + PHP 8 core bootstrap5 theme and custom theme with custom forum templates Important Note:: Updating/Fixing postoptions are/will be separated issues (more than one). It needs some changes but they are not related to this issue. So now just changed links, nothing more. Enhancement Note: $_GET['p'] could be replaced by saving the actual page in post data (like thread works - that information should be available) but it is too complicated now for me and there is a bigger risk that something will not work. Free do it this way if you have time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES #4245
Tested with PHP 8.1
Description:
When you edit a post on the next page (with the paginated topic), after saving you are redirected to the first page and you don't see that edited message then.
Changes
added p parameter to edit URL in post options and edit image shortcodes
used this parameter when redirecting after reply is updated
it is not needed when updating the thread because you are always on the first page
added check if it is the first page, then the parameter is not used (to have the same behavior as with thread).
Tested
PHP 7.4. + PHP 8
core bootstrap5 theme and custom theme with custom forum templates
Important Note::
Updating/Fixing postoptions are/will be separated issues (more than one). It needs some changes but they are not related to this issue. So now just changed links, nothing more.