Skip to content

Replace initramfs code with systemd service#488

Merged
jpoimboe merged 6 commits intodynup:masterfrom
sjenning:rminitrd
Jun 3, 2015
Merged

Replace initramfs code with systemd service#488
jpoimboe merged 6 commits intodynup:masterfrom
sjenning:rminitrd

Conversation

@sjenning
Copy link
Contributor

Remove the dracut support for adding the kpatch modules to the initramfs. This creates a sizable delay in installation time and doesn't offer any added protection over just applying the patches at boot time using a systemd service. Additional, we are seeing more platforms, namely atomic and netboot environments, where changing the initramfs can't be done.

Remove the dracut support for adding the kpatch modules to the
initramfs.  This creates a sizeable delay in installation time and
doesn't offer any added protect over just applying the patches at boot
time using a systemd service.  Additional, we are seeing more platforms,
namely atomic and netboot environments, where changing the initramfs
can't be done.

Signed-off-by: Seth Jennings <[email protected]>
Add a systemd service file for loading of the kpatch modules

Signed-off-by: Seth Jennings <[email protected]>
Signed-off-by: Seth Jennings <[email protected]>
Makefile.inc Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This DRACUTDIR line can be removed

@jpoimboe
Copy link
Member

End comments (though I still haven't tested it yet)

Signed-off-by: Seth Jennings <[email protected]>
@jpoimboe
Copy link
Member

jpoimboe commented Jun 3, 2015

2015-04-29 01:57:00 PM < jpoimboe> sjennings: found an issue in my testing.  by default, kpatch is installed to /usr/local/sbin/kpatch, but the service file looks for it at /usr/sbin/kpatch
2015-04-29 01:57:10 PM < sjennings> ahh yes
2015-04-29 01:57:13 PM < sjennings> :-/
2015-04-29 01:57:24 PM < jpoimboe> may have to do some kind of sed hack when installing the service file?
2015-04-29 01:57:41 PM < sjennings> or just trust $PATH and run "kpatch" :D
2015-04-29 01:57:46 PM < jpoimboe> i.e. replace /usr/sbin/kpatch with $PREFIX/kpatch or something
2015-04-29 01:58:16 PM < jpoimboe> I actually tried just "kpatch", and systemd refused to do it without an absolute path :-)
2015-04-29 01:58:24 PM < sjennings> booo
2015-04-29 01:58:28 PM < jpoimboe> :-)

@jpoimboe
Copy link
Member

jpoimboe commented Jun 3, 2015

One more minor fix -- kpatch.service needs the executable bits removed:

Jun 03 09:02:04 treble systemd[1]: Configuration file /usr/local/lib/systemd/system/kpatch.service is marked executable. Please remove executable permission bits. Proceeding anyway.

Signed-off-by: Seth Jennings <[email protected]>
@sjenning
Copy link
Contributor Author

sjenning commented Jun 3, 2015

sigh. fixed :)

jpoimboe added a commit that referenced this pull request Jun 3, 2015
Replace initramfs code with systemd service
@jpoimboe jpoimboe merged commit de22702 into dynup:master Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants