Conversation
kpatch-build/kpatch-build
Outdated
There was a problem hiding this comment.
Hm, I think I'm missing something. How can the argument to find_kobj ever be something like arch/x86/kvm/../../../virt/kvm/kvm_main.o? The caller of find_kobj is:
FILES="$(find * -type f)"
cd "$TEMPDIR"
mkdir output
declare -A objnames
CHANGED=0
ERROR=0
for i in $FILES; do
mkdir -p "output/$(dirname $i)"
cd "$OBJDIR"
find_kobj $i
It gets the filename from the "find" command. So I would expect the argument to find_kobj to be virt/kvm/kvm_main.o already.
There was a problem hiding this comment.
Oh, it's my fault. I checked changed_objs and found 'arch/x86/kvm/../../../virt/kvm/kvm_main.o'.
Please ingore this patch.
Sorry.
Need I re-open a pull-request?
There was a problem hiding this comment.
No need to open a new pull request. You can just rebase this patch and git push --force to the same branch.
There was a problem hiding this comment.
Sorry for late. I've rebased and pushed again. Thanks.
|
@rousya Looks good to me, can you please rebase to the latest master? |
rela.type should be unsigned int instead of unsighed char. /usr/include/gelf.h:#define GELF_R_TYPE(info) ELF64_R_TYPE (info) /usr/include/elf.h:#define ELF64_R_TYPE(i) ((i) & 0xffffffff) Signed-off-by: Xie XiuQi <[email protected]>
|
Hi @jpoimboe, |
|
👍 |
3 participants
2814237 create-diff-object: fix a potential overflow for rela type
f1683eb kpatch-build: fix ERROR: two parent matches for x.o