Restrict reading old_addr and new_addr to root only#467
Merged
sjenning merged 1 commit intodynup:masterfrom Jan 5, 2015
Merged
Restrict reading old_addr and new_addr to root only#467sjenning merged 1 commit intodynup:masterfrom
sjenning merged 1 commit intodynup:masterfrom
Conversation
Member
|
@flaming-toast Thanks for staying on top of it. We are actually thinking about removing old_addr and new_addr from sysfs altogether. I'd rather leave everything else ( 👍 with the understanding that we may be ripping out this code anyway :-) |
sjenning
added a commit
that referenced
this pull request
Jan 5, 2015
Restrict reading old_addr and new_addr to root only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned on the live-patching mailing list, it is probably a good idea to restrict reading
old_addrandnew_addrto root only, to prevent unprivileged users from gaining information about the kernel's address space.That being said, we could also take this time to double check current permissions in sysfs. Should
checksumandenabledbe readable by root only as well? Should the perms on the kpatch directory in sysfs be more stringent?