Conversation
Dyninst now uses target-based TBB builds, so we need to explicitly provide TBB here. This is a temporary fix until Dyninst exports its targets.
kupsch
reviewed
Oct 24, 2022
Contributor
kupsch
left a comment
kupsch
left a comment
There was a problem hiding this comment.
This looks correct, but the test suite fails to build on mahir (linking libtestdyninst.so fails with undefined reference to 'boost::system::generic_category()'). It does build on coriander.
Contributor
Author
Whoops. I deleted the Boost stuff. Let me fix that. Good check! |
Contributor
Author
|
Subsumed by #217 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dyninst now uses target-based TBB builds, so we need to explicitly provide TBB here. This is a temporary fix until Dyninst exports its targets.