Skip to content

GithubCI: use spack-provided dyninst when building hpctoolkit#1893

Merged
hainest merged 1 commit intomasterfrom
thaines/hpctoolkit_consumer_build
Feb 18, 2025
Merged

GithubCI: use spack-provided dyninst when building hpctoolkit#1893
hainest merged 1 commit intomasterfrom
thaines/hpctoolkit_consumer_build

Conversation

@hainest
Copy link
Copy Markdown
Contributor

@hainest hainest commented Feb 10, 2025

The spack update spack/spack#47637 somehow broke the hpctoolkit install when using the sources in /dyninst/install on Ubuntu-24.10 and Fedora-41. This change has the added benefit of making the usage of spack for building hpctoolkit more idiomatic.

The spack update spack/spack#47637 somehow
broke the hpctoolkit install when using the sources in /dyninst/install
on Ubuntu-24.10 and Fedora-41. This change has the added benefit of
making the usage of spack for building hpctoolkit more idiomatic.
@hainest hainest requested a review from kupsch February 10, 2025 18:14
@hainest hainest self-assigned this Feb 10, 2025
@hainest hainest requested a review from bbiiggppiigg February 12, 2025 13:41
@bbiiggppiigg
Copy link
Copy Markdown
Member

@hainest
I don't have the knowledge of how this PR should be reviewed.
Can you tell me how should I test this?

@hainest
Copy link
Copy Markdown
Contributor Author

hainest commented Feb 12, 2025

@hainest I don't have the knowledge of how this PR should be reviewed. Can you tell me how should I test this?

I manually ran the workflow https://github.com/dyninst/dyninst/actions/runs/13247587990. It's good to go.

@hainest
Copy link
Copy Markdown
Contributor Author

hainest commented Feb 18, 2025

@bbiiggppiigg If/when you have a moment, could you take a quick look at this again?

@hainest
Copy link
Copy Markdown
Contributor Author

hainest commented Feb 18, 2025

Thanks!

@hainest hainest merged commit 0663df8 into master Feb 18, 2025
@hainest hainest deleted the thaines/hpctoolkit_consumer_build branch February 18, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants