Skip to content

Completed tasks#26

Merged
nelsonic merged 8 commits intomasterfrom
completed-tasks-#25
May 26, 2021
Merged

Completed tasks#26
nelsonic merged 8 commits intomasterfrom
completed-tasks-#25

Conversation

@SimonLab
Copy link
Copy Markdown
Member

@SimonLab SimonLab commented Feb 12, 2021

ref: #25

@SimonLab SimonLab self-assigned this Feb 12, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2021 •
edited
Loading

Codecov Report

Merging #26 (6344af7) into master (288d0ff) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines           62        84   +22     
=========================================
+ Hits            62        84   +22
Impacted Files Coverage Δ
lib/models/todoList.dart 100.00% <100.00%> (ø)
lib/screens/completed_tasks/completed_tasks.dart 100.00% <100.00%> (ø)
lib/screens/tasks/tasks.dart 100.00% <100.00%> (ø)
lib/screens/tasks/todolist.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288d0ff...6344af7. Read the comment docs.

@SimonLab SimonLab mentioned this pull request Feb 24, 2021
Merged
@nelsonic
Copy link
Copy Markdown
Member

nelsonic commented May 20, 2021

@SimonLab this is looking good so far. 😍
Please assign when you feel it's ready for review/merge. 👍
Thanks. 🌻

@SimonLab SimonLab assigned nelsonic and unassigned SimonLab May 26, 2021
@SimonLab
Copy link
Copy Markdown
Member Author

SimonLab commented May 26, 2021 •
edited
Loading

I've updated the branch with the code from the master branch and tested that everything is working correctly.
I think this PR is ready for review @nelsonic
Next I'll update the code to add Riverpod, see #27

@SimonLab SimonLab marked this pull request as ready for review May 26, 2021 11:48
@nelsonic nelsonic self-requested a review May 26, 2021 12:21
nelsonic
nelsonic approved these changes May 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks great. 🎉

@nelsonic nelsonic merged commit deca900 into master May 26, 2021
@nelsonic nelsonic deleted the completed-tasks-#25 branch May 26, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels

awaiting-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonLab @nelsonic