Skip to content

[PR] Adding Navbar#314

Merged
nelsonic merged 14 commits intomainfrom
navbar-#305
Feb 23, 2023
Merged

[PR] Adding Navbar#314
nelsonic merged 14 commits intomainfrom
navbar-#305

Conversation

@LuchoTurtle
Copy link
Copy Markdown
Member

@LuchoTurtle LuchoTurtle commented Feb 20, 2023

closes #305

This adds an AppBar according to the Figma design file and an endDrawer, also similar to Figma's design file.
Since the app currently has no further pages, the menu buttons do not redirect the user anywhere.

Additionally, the button is hidden according to a showMenu boolean that can be triggered once the user completes a todolist, hence why the icon is not present at first (see dwyl/product-roadmap#43).

This is still in-progress as I want to get 100% coverage, which the initial implementation of this app does not have 👍

@LuchoTurtle LuchoTurtle added enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person flutter Flutter related issues labels Feb 20, 2023
@LuchoTurtle LuchoTurtle self-assigned this Feb 20, 2023
@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Feb 21, 2023
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Feb 21, 2023
@LuchoTurtle
Copy link
Copy Markdown
Member Author

LuchoTurtle commented Feb 21, 2023

@nelsonic the navbar should be implemented. The reason the coverage is not 100% is that the MyItemList class is not being used. I don't want to delete this because it's part of @SimonLab 's branch, so it's going to be used eventually.

nelsonic
nelsonic reviewed Feb 21, 2023
View reviewed changes
@nelsonic nelsonic assigned LuchoTurtle and unassigned nelsonic Feb 22, 2023
@nelsonic nelsonic added in-progress An issue or pull request that is being worked on by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Feb 22, 2023
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Feb 22, 2023
@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Feb 22, 2023
@LuchoTurtle
Copy link
Copy Markdown
Member Author

LuchoTurtle commented Feb 22, 2023

Re-used the icon. PR should be good to go. 👍

nelsonic
nelsonic reviewed Feb 23, 2023
View reviewed changes
nelsonic
nelsonic approved these changes Feb 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuchoTurtle 👌

@nelsonic nelsonic merged commit 7f689cc into main Feb 23, 2023
@nelsonic nelsonic deleted the navbar-#305 branch February 23, 2023 04:11
@LuchoTurtle LuchoTurtle mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels

awaiting-review An issue or pull request that needs to be reviewed enhancement New feature or enhancement of existing functionality flutter Flutter related issues

Projects

dwyl app kanban
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feat: Basic App Navigation

2 participants

@LuchoTurtle @nelsonic