Repository navigation
Commit f50c17d
authored
fix: avoid invalid date_bin ordering after overflow (apache#25692)
## Which issue does this PR close?
- Closes apache#25690.
## Rationale for this change
`date_bin` advertises its input ordering even when scaling a coarse
timestamp to nanoseconds can overflow and produce a per-row `NULL`. The
optimizer can then remove a required sort and return `NULL` values in
the wrong position.
## What changes are included in this PR?
`date_bin` now reports unordered output for timestamp and time
representations whose conversion to nanoseconds can overflow. Nanosecond
inputs keep their existing ordering propagation, including the sorted
unbounded execution path.
## What is the testing strategy for this PR?
The new `timestamps.slt` regression reproduces the missing final sort
and wrong `NULLS LAST` result on `main`, and passes with this change.
Ablation testing confirmed that the regression fails without the fix.
The focused `timestamps.slt` test passes on this branch.
## Are there any user-facing changes?
Queries involving coarse-precision `date_bin` overflow now honor
requested null ordering. There are no public API changes.1 parent b7ccbbd commit f50c17d
2 files changed
Lines changed: 59 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
273 | 272 | | |
274 | 273 | | |
275 | 274 | | |
276 | 275 | | |
277 | | - | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
278 | 287 | | |
279 | | - | |
| 288 | + | |
280 | 289 | | |
281 | 290 | | |
282 | 291 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1728 | 1728 | | |
1729 | 1729 | | |
1730 | 1730 | | |
1731 | | - | |
| 1731 | + | |
1732 | 1732 | | |
1733 | 1733 | | |
1734 | 1734 | | |
| |||
1750 | 1750 | | |
1751 | 1751 | | |
1752 | 1752 | | |
1753 | | - | |
1754 | | - | |
1755 | | - | |
1756 | | - | |
| 1753 | + | |
| 1754 | + | |
| 1755 | + | |
| 1756 | + | |
| 1757 | + | |
| 1758 | + | |
| 1759 | + | |
| 1760 | + | |
| 1761 | + | |
| 1762 | + | |
| 1763 | + | |
| 1764 | + | |
| 1765 | + | |
| 1766 | + | |
| 1767 | + | |
| 1768 | + | |
| 1769 | + | |
| 1770 | + | |
| 1771 | + | |
| 1772 | + | |
| 1773 | + | |
| 1774 | + | |
| 1775 | + | |
| 1776 | + | |
| 1777 | + | |
| 1778 | + | |
| 1779 | + | |
| 1780 | + | |
| 1781 | + | |
| 1782 | + | |
| 1783 | + | |
| 1784 | + | |
| 1785 | + | |
| 1786 | + | |
| 1787 | + | |
| 1788 | + | |
| 1789 | + | |
| 1790 | + | |
| 1791 | + | |
| 1792 | + | |
| 1793 | + | |
| 1794 | + | |
| 1795 | + | |
| 1796 | + | |
| 1797 | + | |
1757 | 1798 | | |
1758 | 1799 | | |
1759 | 1800 | | |
| |||
0 commit comments