Add equalizer preset management and AutoEQ integration#835
Add equalizer preset management and AutoEQ integration#835dweymouth merged 12 commits intodweymouth:mainfrom
Conversation
b8caf54 to
a9931b0
Compare
|
What do you think about implementing saving and loading EQ presets to files in this PR? ie implement issue #208? My thought is that the presets can be bundled into the app but then saved as editable files when first loaded, and the user can save any customization to them (or create their own new ones) |
Great I proceed |
a9931b0 to
1139a05
Compare
ef07262 to
7969f7f
Compare
|
If all, or almost all, of the AutoEQ presets are for 10-band EQ, perhaps we should just build a 10-band EQ as well. The reason the equalizer is an interface, with an implementation called ISO15BandEqualizer, is that I always envisioned adding other types eventually, like ISO 10-band, and later, parametric. A preset file would then store which type of EQ is is intended for, along with the band gains and preamp. Let me know if you're interested in implementing a 10-band EQ, or if you would like me to add it and then you can rebase this PR against that UI idea: a dropdown select next to the "Enabled" check that switches between the type of EQ - 15 band or 10 band. Loading a preset automatically switches the eq type to the one specified in the preset |
7969f7f to
42663ee
Compare
Done |
42663ee to
7e3b102
Compare
|
What do you think about having both Save and Save As buttons in the EQ dialog? Save would only be enabled if A) a custom preset (ie file-backed) is currently loaded, AND B) the user has made unsaved changes to it. Save As would always be enabled and prompt to choose a new preset name. It can warn and ask for confirmation if you are about to overwrite an existing preset file. I can add Save and Save As icons to the theme, so the buttons can be icon-only with tooltips for space savings. |
|
Thank you for this awesome contribution! |
Implements issue #208 - users can now save, load, and delete custom equalizer presets.
Edit by @dweymouth - this will also implement #274 as well
Preset Management:
Acoustic, R&B, Loudness)
~/.config/supersonic/eq_presets/AutoEQ Integration:
UI:
Refs: