Skip to content

wip: node24#555

Merged
daron1337 merged 6 commits intomasterfrom
node24
Feb 19, 2026
Merged

wip: node24#555
daron1337 merged 6 commits intomasterfrom
node24

Conversation

@daron1337
Copy link
Copy Markdown
Member

@daron1337 daron1337 commented Feb 18, 2026

This pull request updates the project's type coverage reporting workflow, modernizes dependencies, and improves documentation for DICOM data handling. The most significant changes include switching to a new type coverage toolchain, updating Node.js and Cypress dependencies, and clarifying how to use metadata and pixel buffers from PACS in Larvitar.

Type Coverage Reporting Overhaul:

  • Replaced the typescript-coverage-report tool and its associated script (.github/scripts/ts-coverage-summary.js) with a new workflow based on type-coverage and a custom reporting script (.github/scripts/typecov-badge-md.js). The new system generates both text and JSON reports, then creates a Markdown summary with top untyped hotspots. The GitHub Actions workflow and PR comment logic were updated to match the new output. [1] [2] [3] [4] [5]
  • Updated the Node.js version used in CI workflows from 20 to 24 for both documentation and PR builds. [1] [2]
  • Updated package.json scripts and dependencies to remove typescript-coverage-report, add type-coverage, and ensure consistent version pinning for @hyzyla/pdfium and patch-package. [1] [2] [3] [4] [5]

Testing and Cypress Updates:

  • Migrated from cypress-image-snapshot to @simonsmith/cypress-image-snapshot throughout the Cypress config, plugins, and support files for better maintenance and compatibility. [1] [2] [3]
  • Removed a flaky or deprecated test for the "Show Code" modal in cypress/e2e/base.cy.js.

Documentation Improvements:

  • Expanded the parsing documentation to clarify how to use QIDO metadata and pixel buffers directly (without re-parsing DICOM files), and provided example usage of convertQidoMetadata and the Single Frame Loader. [1] [2]
  • Minor doc corrections for the Single Frame Loader and example HTML files. [1] [2] [3]

Other Codebase Updates:

  • Fixed a minor bug in the HSVtoRGB function by wrapping assignments in parentheses for clarity and correctness.
  • Bumped the package version to 3.8.7.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 19, 2026

🔍 Cypress Test Results

Status: ✅ All tests passed
Pass Rate: 100.00%
Total Tests: 32
Passed: 32
Failed: 0
Pending/Skipped: 0
Duration: 68.59s

📊 Test Suite Details

Suite Status Pass % Total Passed Failed Pending
Root > Testing the base.html functionalities 100.00% 13 13 0 0
Root > Larvitar DICOM Viewer 100.00% 1 1 0 0
Root > Larvitar - Default Tools Example 100.00% 3 3 0 0
Root > Larvitar DSA Rendering 100.00% 2 2 0 0
Root > Larvitar ECG Rendering 100.00% 6 6 0 0
Root > Larvitar Multiframe Rendering 100.00% 4 4 0 0
Root > Larvitar DICOM PDF Rendering 100.00% 1 1 0 0
Root > Testing the 4d.html functionalities 100.00% 2 2 0 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 19, 2026

🧪 Type Coverage

92.91%

(19056 / 20510)

███████████████████░ 92.91%
Target: 90%

Top hotspots (untyped occurrences)

File Uncovered
imaging/imageRendering.ts 240
imaging/imageUtils.ts 142
imaging/parsers/nrrd.js 138
imaging/imageTools.ts 112
imaging/imageParsing.ts 100

@daron1337 daron1337 marked this pull request as ready for review February 19, 2026 08:38
@daron1337 daron1337 merged commit 4b2e827 into master Feb 19, 2026
1 check passed
@daron1337 daron1337 deleted the node24 branch February 19, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants