Skip to content

Add SelectMenuTile#254

Merged
Pante merged 11 commits intomainfrom
feature/select-menu-tile
Nov 8, 2024
Merged

Add SelectMenuTile#254
Pante merged 11 commits intomainfrom
feature/select-menu-tile

Conversation

@Pante
Copy link
Copy Markdown
Member

@Pante Pante commented Nov 4, 2024 •
edited
Loading

Describe the changes
This PR introduces the SelectMenuTile.

Fixes #207, #162 .

Checklist

  • I have read the CONTRIBUTING.md.
  • I have included the relevant unit/golden tests.
  • I have included the relevant samples.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG.md if necessary.

@Pante Pante requested a review from kawaijoe November 4, 2024 08:17
@Pante Pante self-assigned this Nov 4, 2024
@Pante Pante temporarily deployed to docs-development November 4, 2024 08:17 — with GitHub Actions Inactive
@Pante Pante linked an issue Nov 4, 2024 that may be closed by this pull request
Select Component #162
Closed
@auto-maid2 auto-maid2 Bot temporarily deployed to docs-development November 4, 2024 08:18 Inactive
@auto-maid2
Copy link
Copy Markdown
Contributor

auto-maid2 Bot commented Nov 4, 2024 •
edited
Loading

Documentation Preview

Latest Commit SHA 11681a7
Preview URL https://2f2433ae.forui-docs-dev.pages.dev/docs

You're seeing this because the docs/samples were updated.

@kawaijoe kawaijoe requested a review from Daviiddoo November 4, 2024 08:38
kawaijoe
kawaijoe reviewed Nov 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kawaijoe kawaijoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, I don't think this PR resolves #162.

Comment thread docs/pages/docs/tile/select-menu-tile.mdx
Comment thread forui/lib/src/widgets/label.dart
Comment thread forui/lib/src/widgets/select_group/select_group_controller.dart
Comment thread forui/lib/src/widgets/select_menu_tile.dart Outdated
@Pante Pante temporarily deployed to docs-development November 4, 2024 11:59 — with GitHub Actions Inactive
@auto-maid2 auto-maid2 Bot temporarily deployed to docs-development November 4, 2024 12:01 Inactive
@Pante Pante removed a link to an issue Nov 5, 2024
Select Component #162
Closed
@Pante
Copy link
Copy Markdown
Member Author

Pante commented Nov 5, 2024

On a side note, I don't think this PR resolves #162.

I thought about and it seems really similar IMO. You just need to remove the dividers in the menu and it'll look kinda close?

@Pante Pante force-pushed the feature/select-menu-tile branch from dde9a4a to 944870c Compare November 5, 2024 06:07
@Pante Pante temporarily deployed to docs-development November 5, 2024 06:07 — with GitHub Actions Inactive
@auto-maid2 auto-maid2 Bot temporarily deployed to docs-development November 5, 2024 06:09 Inactive
@Pante Pante force-pushed the feature/select-menu-tile branch from e9edd1c to a96e5ca Compare November 5, 2024 06:11
@Pante Pante temporarily deployed to docs-development November 5, 2024 06:11 — with GitHub Actions Inactive
@auto-maid2 auto-maid2 Bot temporarily deployed to docs-development November 5, 2024 06:13 Inactive
@kawaijoe
Copy link
Copy Markdown
Contributor

kawaijoe commented Nov 5, 2024

On a side note, I don't think this PR resolves #162.

I thought about and it seems really similar IMO. You just need to remove the dividers in the menu and it'll look kinda close?

It's really different, select isn't in a tile. It's a form element that should exist with TextField, Radio, and etc.

@Pante Pante force-pushed the feature/select-menu-tile branch from d1b89ff to 1eb0a6c Compare November 5, 2024 11:16
@Pante Pante temporarily deployed to docs-development November 5, 2024 11:16 — with GitHub Actions Inactive
@Pante Pante mentioned this pull request Nov 5, 2024
Closed
@Pante Pante temporarily deployed to docs-development November 5, 2024 14:33 — with GitHub Actions Inactive
@Pante Pante force-pushed the feature/select-menu-tile branch from 4c830d3 to f3bd856 Compare November 6, 2024 06:49
@Pante Pante temporarily deployed to docs-development November 6, 2024 06:49 — with GitHub Actions Inactive
@Pante Pante force-pushed the feature/select-menu-tile branch from f3bd856 to 8482a07 Compare November 6, 2024 06:52
@Pante Pante temporarily deployed to docs-development November 6, 2024 06:52 — with GitHub Actions Inactive
@Pante Pante force-pushed the feature/select-menu-tile branch from 8482a07 to 3a39bf3 Compare November 6, 2024 07:24
@Pante Pante temporarily deployed to docs-development November 6, 2024 07:24 — with GitHub Actions Inactive
@Pante Pante temporarily deployed to docs-development November 7, 2024 01:40 — with GitHub Actions Inactive
@Pante Pante force-pushed the feature/select-menu-tile branch from 971a85d to 5cb1496 Compare November 7, 2024 01:43
@Pante Pante temporarily deployed to docs-development November 7, 2024 01:44 — with GitHub Actions Inactive
@Pante Pante force-pushed the feature/select-menu-tile branch from 5cb1496 to 11681a7 Compare November 8, 2024 05:57
@Pante Pante temporarily deployed to docs-development November 8, 2024 05:57 — with GitHub Actions Inactive
@Pante Pante merged commit f9539da into main Nov 8, 2024
@Pante Pante deleted the feature/select-menu-tile branch November 8, 2024 06:13
@Ez3kiel-dev Ez3kiel-dev mentioned this pull request Jul 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kawaijoe kawaijoe kawaijoe approved these changes

@Daviiddoo Daviiddoo Awaiting requested review from Daviiddoo

Assignees

@Pante Pante

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SelectTile

2 participants

@Pante @kawaijoe