Skip to content

Line calendar #174

Merged
Daviiddoo merged 46 commits intomainfrom
feature/line_calendar
Nov 7, 2024
Merged

Line calendar #174
Daviiddoo merged 46 commits intomainfrom
feature/line_calendar

Conversation

@Daviiddoo
Copy link
Copy Markdown
Contributor

@Daviiddoo Daviiddoo commented Aug 29, 2024 •
edited
Loading

Describe the changes

Checklist

  • I have read the CONTRIBUTING.md.
  • I have included the relevant unit/golden tests.
  • I have included the relevant samples.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG.md if necessary.

@Daviiddoo Daviiddoo requested a review from Pante August 29, 2024 15:34
Pante
Pante requested changes Aug 30, 2024
View reviewed changes
Comment thread forui/lib/src/widgets/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar.dart Outdated
Comment thread forui/test/src/widgets/line_calendar_golden_test.dart
Comment thread forui/test/src/widgets/line_calendar_golden_test.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar.dart Outdated
@Pante Pante linked an issue Sep 19, 2024 that may be closed by this pull request
Linear calendar #149
Closed
@Daviiddoo Daviiddoo force-pushed the feature/line_calendar branch from 9197a80 to 3c186b0 Compare September 29, 2024 17:14
@Daviiddoo Daviiddoo marked this pull request as draft October 2, 2024 12:54
@Daviiddoo Daviiddoo requested review from Pante and kawaijoe and removed request for Pante and kawaijoe October 2, 2024 12:54
@Daviiddoo Daviiddoo self-assigned this Oct 2, 2024
@Daviiddoo Daviiddoo force-pushed the feature/line_calendar branch from 5670028 to d195afa Compare October 20, 2024 07:37
@auto-maid2
Copy link
Copy Markdown
Contributor

auto-maid2 Bot commented Oct 23, 2024 •
edited
Loading

Documentation Preview

Latest Commit SHA 750f70c
Preview URL https://2f41064d.forui-docs-dev.pages.dev/docs

You're seeing this because the docs/samples were updated.

@Daviiddoo Daviiddoo force-pushed the feature/line_calendar branch from 1f0e760 to 4347711 Compare October 30, 2024 05:28
@Daviiddoo Daviiddoo requested a review from Pante November 4, 2024 08:54
Pante
Pante requested changes Nov 4, 2024
View reviewed changes
Comment thread forui/lib/src/theme/theme_data.dart
Copy link
Copy Markdown
Member

@Pante Pante Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, would this be an issue if we release 0.7.0 and the line calendar field is left in? @kawaijoe

Comment thread forui/lib/src/widgets/line_calendar/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar/line_calendar_tile.dart Outdated
Comment thread forui/test/src/widgets/line_calendar_golden_test.dart Outdated
Comment thread forui/test/src/widgets/line_calendar_golden_test.dart Outdated
Comment thread forui/test/src/widgets/line_calendar_golden_test.dart
Comment thread forui/test/src/widgets/line_calendar_golden_test.dart
@auto-maid2 auto-maid2 Bot temporarily deployed to docs-development November 5, 2024 10:22 Inactive
@Pante Pante mentioned this pull request Nov 5, 2024
Closed
@auto-maid2 auto-maid2 Bot temporarily deployed to docs-development November 7, 2024 09:08 Inactive
Pante
Pante requested changes Nov 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Pante Pante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems okay, just a few minor things.

Comment thread forui/lib/src/widgets/line_calendar/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar/line_calendar.dart Outdated
Comment thread forui/lib/src/widgets/line_calendar/line_calendar.dart Outdated
Pante
Pante approved these changes Nov 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Pante Pante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Daviiddoo Daviiddoo merged commit 9fa18d8 into main Nov 7, 2024
@Daviiddoo Daviiddoo deleted the feature/line_calendar branch November 7, 2024 17:10
@Ez3kiel-dev Ez3kiel-dev mentioned this pull request Jul 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kawaijoe kawaijoe kawaijoe left review comments

@Pante Pante Pante approved these changes

Assignees

@Daviiddoo Daviiddoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linear calendar

3 participants

@Daviiddoo @kawaijoe @Pante