feat: Add --no-spawn-shell flag to disable shell access #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new flag, --no-spawn-shell, which disables the ability to spawn a shell or open items in external programs. This is useful for environments where shell access should be restricted. This resolves issue dundee#429.
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #440 +/- ##
==========================================
- Coverage 83.49% 83.45% -0.05%
==========================================
Files 46 46
Lines 4412 4449 +37
==========================================
+ Hits 3684 3713 +29
- Misses 656 662 +6
- Partials 72 74 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The test failure was due to a "data race" in a test called TestRemoveStoredFile. please check. |
Contributor
Author
|
Moving a.wait.Done() after the progress channel update prevents race conditions between ResetProgress and processDir accessing shared data. This placement is unconventional and warrants a thorough review. |
Contributor
Author
|
@dundee please check |
dundee
approved these changes
Oct 16, 2025
Owner
|
Thank you! |
zoza1982
pushed a commit
to zoza1982/gdu
that referenced
this pull request
Oct 23, 2025
* feat: Add --no-spawn-shell flag to disable shell access This commit introduces a new flag, --no-spawn-shell, which disables the ability to spawn a shell or open items in external programs. This is useful for environments where shell access should be restricted. This resolves issue dundee#429. * test: Increase coverage for --no-spawn-shell flag * fix: data race in TestRemoveStoredFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new flag, --no-spawn-shell, which disables the ability to spawn a shell or open items in external programs. This is useful for environments where shell access should be restricted. Fixes #429