ci: use Golang 1.24.4 #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 83.50% 83.57% +0.06%
==========================================
Files 46 46
Lines 4408 4408
==========================================
+ Hits 3681 3684 +3
+ Misses 655 653 -2
+ Partials 72 71 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dundee
reviewed
Jul 8, 2025
go.mod
Outdated
| module github.com/dundee/gdu/v5 | ||
|
|
||
| go 1.22 | ||
| go 1.24.4 |
Owner
There was a problem hiding this comment.
I'm afraid we cannot bump this yet.
I would like to keep support for latest LTS version of Ubuntu - currently 24.04 Noble Numbat, which uses Golang 1.22.
Contributor
Author
There was a problem hiding this comment.
In that case we can go ahead and close out this PR?
There are a couple of "corrections" from my previous PR though. Those can be done later, I guess.
Owner
There was a problem hiding this comment.
I have removed go.mod and go.sum from the PR and will merge it.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--mousein correct alphabetical locationgit get -u ./... && go mod tidy