Skip to content

feat:add GetExeDllVersion for fileutil,random,package #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
duke-git merged 6 commits into from
Oct 18, 2024
Merged

feat:add GetExeDllVersion for fileutil,random,package #257

duke-git merged 6 commits into from
Oct 18, 2024

Conversation

@jwwsjlm
Copy link
Contributor

@jwwsjlm jwwsjlm commented Oct 17, 2024 •
edited
Loading

GetExeDllVersion 函数,用于获取exe和dll的版本号.
RandNumLen 函数,用于获取指定长度的随机数.

@duke-git
Copy link
Owner

duke-git commented Oct 18, 2024 •
edited
Loading

@jwwsjlm 参考以下问题：

  1. 支持这个功能需要引入额外的依赖库golang.org/x/sys/。（不需要引入这个库也可以实现功能）
  2. 如果仅支持windows需要添加条件编译指令（// +build windows)
  3. 代码中错误信息需要用英文.
  4. 测试代码中的路径（C:\Program Files\Tencent\WeChat\WeChat.exe）在其他平台运行会报错。
  5. main分支已锁定，修改后可以合并到rc分支。

@jwwsjlm
Copy link
Contributor Author

jwwsjlm commented Oct 18, 2024

@jwwsjlm 参考以下问题：

  1. 支持这个功能需要引入额外的依赖库golang.org/x/sys/。（不需要引入这个库也可以实现功能）
  2. 如果仅支持windows需要添加条件编译指令（// +build windows)
  3. 代码中错误信息需要用英文.
  4. 测试代码中的路径（C:\Program Files\Tencent\WeChat\WeChat.exe）在其他平台运行会报错。
  5. main分支已锁定，修改后可以合并到rc分支。
    2的话 是新建一个file_windows这样吗?

@duke-git
Copy link
Owner

duke-git commented Oct 18, 2024

@jwwsjlm 合并到rc分支，main分支已锁定

@jwwsjlm jwwsjlm changed the base branch from main to rc October 18, 2024 07:48
@jwwsjlm jwwsjlm changed the title feat:add GetExeDllVersion for fileutilpackage feat:add GetExeDllVersion for fileutil,random,package Oct 18, 2024
@duke-git duke-git merged commit ed93aae into duke-git:rc Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duke-git duke-git duke-git approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jwwsjlm @duke-git